Indent and structure code

Is it follow good code practices?