This block will only be executed if the temp file exists. Are you saying
there are cases where we definitely *don't* want to clean up after
ourselves? Could you enumerate some?


On Thu, Feb 20, 2014 at 8:38 AM, Anthony Scopatz
<notifications@github.com>wrote:

> In tests/test_regression.py:
>
> > @@ -59,7 +59,7 @@ def test_regression(check_deterministic=False):
> >              if os.path.isfile(tmp_file):
> >                  try:
> >                      nondeterm = compare_nondeterm(sim_files[f], tmp_file)
> > -                except KeyError:
> > +                except Exception:
>
> This is pretty much against best practices. This should be a tuple of all
> specific exceptions that the try block throw. I can think of cases where we
> might not want to call os.remove(), like when someone presses ^C.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cycamore/pull/193/files#r9907773>
> .
>



-- 
Matthew Gidden
Ph.D. Candidate, Nuclear Engineering
The University of Wisconsin -- Madison
Ph. 225.892.3192