Changed functionality of getGrossValue and added getNetValue. Added and ...

...fixed documentation

@adamvoncorswant @mikaellothman 

Hope we didn't do duplicate work mikael, sorry if we did!

I think we need to call it net and not just value because there are a lot of functions named somethingValue.
Ok, let's go for value! Let's also keep it up with the nice docs and we
should be ok!
On Sep 17, 2014 7:24 PM, "Adam von Corswant" <notifications@github.com>
wrote:

> In izettle-cart/src/main/java/com/izettle/cart/Item.java:
>
> >  			return round(getNonRoundedDiscountValue(discount, valueBeforeDiscounts));
> >  		}
> >  		return null;
> >  	}
> >
> > -	private BigDecimal getValueBeforeDiscounts() {
> > +	private BigDecimal getBigDecimalGrossValue() {
>
> Yeah, possibly...
>
> The thing is that I had this crazy long discussion with @MrShish
> <https://github.com/MrShish> and @idlefingers
> <https://github.com/idlefingers> about this naming. After going back and
> forth, both IRL and on GH, we finally settled on that value appeared the
> best term for anything that represents a real-world cost for something.
>
> Also, the specificity that you suggest rather adds to the confusion in my
> mind. If named netOfDiscount, you would all of a sudden start to wonder
> whether VAT is included or not...
>
> Just value is fine, because that's like the end of the funnel. It's what
> everything boild down to. The monetary value of the cart.
>
> Well well. Naming is hard :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/iZettle/izettle-toolbox/pull/89/files#r17679085>.
>