Profoundly apologize for not doing a full set of testing. My bad...

Sam.


On Wed, May 14, 2014 at 3:54 PM, Larry Gritz <notifications@github.com>wrote:

> In src/dpx.imageio/libdpx/Writer.cpp:
>
> > @@ -225,6 +241,10 @@ bool dpx::Writer::WriteElement(const int element, void *data, const DataSize siz
> >  	if (this->header.ImageDescriptor(element) == kUndefinedDescriptor)
> >  		return false;
> >
> > +    // The DPX spec recommends that the image data starts on a 8K boundry.
> > +    if (this->WritePadData(0x2000))
>
> Should this be
>
> if (! this->WritePadData(0x2000))
>
> Strange that this module seems to have "this->" all over the place
> needlessly. (Not your fault, and DON'T change it as part of this review!)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/OpenImageIO/oiio/pull/853/files#r12666519>
> .
>