Documentation followup to r1616584
- s/try/true/
- explain what "current classloader" is
- format values with <code>

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617115 13f79535-47bb-0310-9956-ffa450edef68
Review of r1616584
- Explicitly reference the classloader of PoolProperties class, to keep the old behaviour of Class.forName.
It matters in unlikely theoretical case if PoolProperties$InterceptorDefinition class is being extended (subclassed).
- s/StringBuffer/StringBuilder/

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617165 13f79535-47bb-0310-9956-ffa450edef68
Followup to r1616570
Correct a copy-paste. Fix missing trailing stop in sentences.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617178 13f79535-47bb-0310-9956-ffa450edef68
Use root just created rather than new object

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617234 13f79535-47bb-0310-9956-ffa450edef68
This can get called a lot and this appears to be marginally faster

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617242 13f79535-47bb-0310-9956-ffa450edef68
Add simple caching support for calls to getResources()

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617265 13f79535-47bb-0310-9956-ffa450edef68
Update change log

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617266 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56318
The weak reference is for the statement itself.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617355 13f79535-47bb-0310-9956-ffa450edef68
Silence some unnecessary nags

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617359 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56829
Add the ability for users to define their own values for _RUNJAVA and _RUNJBD. Based on a patch by Neeme Praks.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617362 13f79535-47bb-0310-9956-ffa450edef68
Improve comments

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617365 13f79535-47bb-0310-9956-ffa450edef68
Fix typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617373 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56829
Review of r1617362. Correct a copy-paste in condition.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617383 13f79535-47bb-0310-9956-ffa450edef68
Correct a typo

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617386 13f79535-47bb-0310-9956-ffa450edef68
Restore !included test to correct location
Some other component (e.g. filter) may have already set the vary header so account for that.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617443 13f79535-47bb-0310-9956-ffa450edef68
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56825
Enable pre-emptive authentication to work with the SSL authenticator. Based on a patch by jlmonteiro.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617445 13f79535-47bb-0310-9956-ffa450edef68
Followup to fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56829
Be more strict with executable filename on Windows (s/java/java.exe/).

When file name extension is not specified, Windows uses the value of %PATHEXT% environment variable to enumerate applicable filename extensions.
On my Windows 7 its value is ".COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC".
I think it is a bit more secure if filename is specified explicitly.

There shall be no observable difference in behaviour, as .EXE is at the start of the PATHEXT list (e.g. earlier than .BAT).

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617456 13f79535-47bb-0310-9956-ffa450edef68
Follow-on to r1617445
If a client certificate is required and one is not available then force renegotiation to obtain it.
If a client certificate is optional then do not force renegotiation before trying to obtain it.

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617461 13f79535-47bb-0310-9956-ffa450edef68
Follow-up to 1617445.
Updated expected value that has changed in 1617445

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617469 13f79535-47bb-0310-9956-ffa450edef68
Review of fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56801
Revert public API changes from r1615876

I think match(String, char[], boolean) is a bad signature to expose such method as public.

My concerns:
a) Maybe there is a way to cache String->char[] conversions for the pattern set as well.
In that case the method signature will become (char[],char[],..).
As of now the current improvement is an incomplete one.

b) I am not sure that using String vs char[] array has much difference.
Is it worth to stick to char[] in the API?

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1617470 13f79535-47bb-0310-9956-ffa450edef68