Fix and re-enable test_disassociate_not_associated_floating_ip

Fixes test_disassociate_not_associated_floating_ip so it sets the
ec2_client class variable needed by a base class correctly. There
has been some bit-rot since it was disabled.

Note that this test will not pass until the nova fix
https://review.openstack.org/#/c/124320/ has merged.

Change-Id: Ice39358f4e8123334f24056daede68bead59729b
Related-Bug: 1179816
Create subnet without gateway and explicit IP ver

Now it's impossible to create subnet without gateway in network
tests. This patch allows you to set gateway explicitly to None.
Backward compatibility is supported: by default it creates
subnet with default gateway as before. Also it adds possibility
to create subnet with specific IP version when you need to create
two subnets in one tenant of different IP version ("dual-stack").
Fixed attributes test for new requirements and added 2 anothers.

Change-Id: I7aca5e07be436f20cba90339785b46182d97fead
Migrate cli test framework to tempest-lib

This commit switches the cli tests to use tempest-lib. The code which
was migrated to tempest-lib is removed and all the existing test cases
are converted to use the framework provided by the library. Future
improvements to the cli testing framework should be made in
tempest-lib after this commit.

Partially implements bp tempest-library
Change-Id: If2c9b3895a30905bc3d62b8daef783878d78399a
Switch to using subunit-trace from tempest-lib

This commit removes the tempest copy of subunit-trace and uses the
entry-point from tempest-lib instead.

Partially implements bp tempest-library

Change-Id: Ic1aeddc2d0b217c41b6b9914ac3f269b80c4ec8e
Add list-networks test for os-networks API

Adds a test to list networks for a non-admin tenant
using the compute os-networks API.

For Flat* network managers in nova, a tenant is not
assigned to a network so this tests that when listing
networks with a non-admin tenant, we get something back
since the underlying code in nova should pass 'allow_none'
to the DB API when listing the networks for Flat and
FlatDHCP network managers.

Change-Id: I5c50607279a8a385ebe96bf498e3e95079d6dec1
Related-Bug: #1327406
Merge "Fix and re-enable test_disassociate_not_associated_floating_ip"
Fix the flavor ram string value

Current test_create_flavor_using_string_ram specify " 1024 " as the
ram string value and the spaces are meaningless.
Current Nova API(v2.0) validation is loose and the API accepts this
value. However, new API(v2.1) will not allow this kind of value.
This patch removes these spaces from the test.

Change-Id: Ifaabcf04e2600bcec8043c981e320d47d8dc6379
Correct docstring indentation

Change-Id: Ifb4ad284f2a36eb6ab42ae2f344f030215186d69
Merge "Add list-networks test for os-networks API"
Merge "Fix the flavor ram string value"
Merge "Correct docstring indentation"
Merge "Migrate cli test framework to tempest-lib"
Merge "Switch to using subunit-trace from tempest-lib"
Change CLI tests to use auth providers

This commit changes the CLI tests to use the auth providers for
credentials. Previously they were just using the admin credentials
straight from the config file. The typical motivation for doing this
would be tenant isolation for running in parallel, but that doesn't
apply to the CLI tests because they are simple read-only. However, in
the future when test-accounts supports admin credentials doing this
won't be supported.

Change-Id: Iad5fe6e8abe4491d10e9a676a1c2a7da05a38113
Increase the 'all' timeout because slow tests are included

The default for tempest in .testr.conf is 500s. This was too short for
the heat slow tests so the time for that was increased to 1200. This
change is to a periodic job so if we need to it can be increased more
in the future.

Change-Id: If27ddef9865c54b997130c707382d2014d82e0a6
Fixed a comment on dirty logs list

We've recently changed default behaviour to forbid any dirty logs for
services outside the list instead of explicitly enabling log checks for
specific services. The comment was not updated to reflect the change
though.

Change-Id: I5d5ba64d156a9b5318cfc2740b2a69d75de3c127
Merge "Change CLI tests to use auth providers"
Add wait for async secgroup add to minimum basic scenario

Security group add actions are asynchronous so we can't assume that
the security will be available immediately to ssh into the server.
This commit fixes the issue by adding a wait for the secgroup to show
up in the server before we move on.

Fixes-bug: 1390355
Change-Id: Idd561d77ce2e4b83421bb7bfb6327a6c940b62ed
Remove ephemeral size assertion in baremetal scenario

The test currently fails if the the baremetal flavor has no
ephemeral disk set.  This removes an unnecessary assertion and
unblocks tests against environments that do not deploy ephemeral
disks.

Change-Id: I7f13d4d7b40ea8879eaa30a19c117aef284586ff
Merge "Increase the 'all' timeout because slow tests are included"