I was confused about the semantics here. I suppose !@watcher.nil? might be
better?
On Apr 3, 2014 10:43 AM, "Will Moss" <notifications@github.com> wrote:

> In lib/synapse/service_watcher/zookeeper.rb:
>
> > @@ -96,8 +109,14 @@ def discover
> >      def watch
> >        return if @should_exit
> >
> > -      @watcher.unsubscribe if defined? @watcher
> > +      @watcher.unsubscribe if @watcher
>
> Are we sure @watcher is defined? I don't see it being created in
> initialize or anywhere else that would guarantee it's existence.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/airbnb/synapse/pull/56/files#r11263203>
> .
>