dockertest.subtest: Reformat logging and fix couple of bugs

This patch changes the logging method to respect these rules:
1) debug - copy&paste friendly, not necessarily nice
2) warning,error,info - manager frienly, emphasize multiline messages
                        by space-based indentation

By design this changes the issues of silently ignored messages when
lines with arguments were used (eg. `self.loginfo("test %s", 1)`)

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
subtest: Fix run cleanup problem.

Signed-off-by: Jiří Župka <jzupka@redhat.com>
subtests.docker_cli.start: Modify start test to new docker behavior

The `docker start` command should only return 0, when the container
is already running.

https://bugzilla.redhat.com/show_bug.cgi?id=1090071

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
subtests.docker_cli.start: Code and style cleanups

This patch removes duplicite postprocess, adds timeout for bg process
and fixes some pep8 style fixes. There is no real test-logic change.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Dockertest Version 0.7.5 (No API Changes)

Signed-off-by: Chris Evich <cevich@redhat.com>
subtests...run_volumes: logging fix

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge branch 'start_simple' of https://github.com/ldoktor/autotest-docker
subtests...start: Fix catchall in cleanup()

Specific exceptions defined for expected/likely error
behavior, anything else is a possible bug somewhere.

Signed-off-by: Chris Evich <cevich@redhat.com>
subtests...start: Simplify configuration

*  Removed unused ``docker_start_force`` option.
*  All tests expected to PASS now, removed option.
*  Made ``check_if_cmd_finished`` into class variable
   for one sub-subtest that uses it.
*  Utilize parent defaults for ``docker_attach``
   and ``docker_interactive`` options.
*  Updated documentation

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge branch 'run_cleanup' of https://github.com/jzupka/autotest-docker
Merge pull request #154 from cevich/docker_0.7.5

Docker 0.7.5
Docker: Add firewalld/iptables test

Signed-off-by: Time Su <lsu@redhat.com>
subtests...iptable: Doc. update

Signed-off-by: Chris Evich <cevich@redhat.com>
docker_daemon: Adds test for testing docker daemon icc parameter.

Signed-off-by: Jiří Župka <jzupka@redhat.com>
Docker: Pylint cleanup

*  Clarify DockerContainersBase.remove_by_name() raises
   ValueError if container is not found with name.
*  Ignore SpecificServiceManager implementation pylint problems
*  More descriptive names in output.wait_for_output()
*  Fix module namespace/scoping problem in network test
*  Fix too-long line in network test
*  Fix ignoring OutputGood exception in network test.
*  Fix setting attribute outside init in network test
*  Removed TODO in help test (resolved in later version)
*  Unused import removal from syslog test

Signed-off-by: Chris Evich <cevich@redhat.com>
subtests...network: Wait for container start

Use standard utils.wait_for() call to poll on container start
to get ip address using docker inspect.  Give sufficiently
long timeout incase of image load.

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge pull request #188 from cevich/master

Network icc + fixups
dockertest: Doc. bug.

Clarify ``stuff`` and ``sub_stuff`` as dictionary-types, initialized
empty.  Using them as another type, requires re-assigning during
``initialize()`` since static assignment would otherwise get clobbered
in the constructor.

Signed-off-by: Chris Evich <cevich@redhat.com>
Merge pull request #187 from cevich/no_clobber_stuff

dockertest: Doc. bug.
subtests...All: Pylint disable removal.

*  Disables now managed centrally in ``run_pylint.sh`` script.
*  Fixed two small pylint problems in tests

Signed-off-by: Chris Evich <cevich@redhat.com>