Controlling the behavior through the configuration file looks more like a workaround to me.
As a user, I prefer the way that we can control the section through the command line.
Sharad and folks, how to you think?

From: Ritesh Maheshwari <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Friday, May 9, 2014 at 10:00 AM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Chaoyue Xiong <cxiong@linkedin.com<mailto:cxiong@linkedin.com>>
Subject: Re: [naarad] Homepage redesign (#225)


In bin/naarad:

> @@ -169,6 +169,7 @@ def main():
>    arg_parser.add_argument('-d', '--diff', nargs=2, help="Specify the location of two naarad reports to diff separated by a space. Can be local or http(s) locations. The first report is used as a baseline.", metavar=("report-1", "report-2"))
>    arg_parser.add_argument('-n', '--no_plots', help="Don't generate plot images. Useful when you only want SLA calculations. Note that on-demand charts can still be generated through client-charting.", action="store_true")
>    arg_parser.add_argument('-e', '--exit_code', help="optional argument to enable exit_code for naarad", action="store_true")
> +  arg_parser.add_argument('--sub_important_enabled', help="Whether to enable display of important sub metric in the summary report 0:disabled, 1: enabled", action="store_true")


I don't think we need to add another command line option to do that. You can just set empty "important_sub_metrics" for each section:

[GC]
infile=gc.log
important_sub_metrics=


—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/225/files#r12485129>.