Xaw client: Remove hard coded dependency on the Spy flag in spy actions against a city

The actions an unit with the Diplomat flag can do against a city is now
determined by action enablers, not by the presence of the Spy flag. Merging
the dialogs makes the Xaw client do the right thing in rule sets where a
diplomat without the Spy flag can to targeted actions and in rule sets where
a unit with the Spy flag can do untargeted actions.

See patch #4472

git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24347 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
SDL clients: Allow units that don't have the Spy flag to do targeted sabotage

It is possible to let units that don't have the Spy flag do targeted
sabotage via action enablers. Stop failing silently when a non Spy unit
receive the list of possible sabotage targets.

See bug #21588

git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24348 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Xaw client: Merge spy action dialogs

See patch #4473

git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24349 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Made it tileset configurable on top of which terrain layer darkness is applied.

Requested by Jacob Nevins <jtn>

See patch #4461


git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24350 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Client starts looking free server port from (DEFAULT + 1) to mitigate
Windows bug of binding to port that is already used by manually started server

Bug reported by Jacob Nevins <jtn>

See patch #4471


git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24352 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Replaced commandline parameter to select ruleset to edit in freeciv-ruledit with
gui implementation.

See patch #4462


git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24355 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Qt client: inline the variable diplomat_target_id to avoid confusion

In other clients the variable diplomat_target_id is a global array of
possible targets. In the Qt client it is local to popup_diplomat_dialog().

See patch #4475

git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24358 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Xaw client: permit targeted sabotage of building 0 (Airport in Classic)

Change the validation test to check the the building ID isn't below -1

Reported by Jacob Nevins <jtn>

See bug #21560

git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24359 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Don't battle your own on the behalf of the ally you spy on.

If a unit that has the Diplomat flag or the SuperSpy flag is on the same
tile as the target of certain diplomat actions it will try to stop them via
diplomatic combat. A unit should not try to stop an action done by it self
or another unit controlled by the same player.

See bug #21596

git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24360 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Fix Diplomat/Spy actions against a victim on the same tile as the Diplomat

The offending line cause silent failure unless the Spy/Diplomat action
dialog of another unit is open. Remove it in stead of inverting it. No
matter if the check is there or not the Spy/Diplomat action dialog currently
showing will remain the same. Without the check the new order will be queued
in stead of silently forgotten.

See bug #21595

git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24361 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Updated civ2civ3 ruleset to version 6.

Patch by David Fernandez <bardo>

See patch #4460


git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24371 a0f10bec-cc02-0410-94fc-a9cfff90b4cd
Added tags for specialists unused in supplied rulesets but present in specialists.png.

See patch #4467


git-svn-id: svn://svn.gna.org/svn/freeciv/trunk@24373 a0f10bec-cc02-0410-94fc-a9cfff90b4cd