Fixed the following:
- You only have one class but you should probably still use a namespace.
- https://github.com/abrock17/KeySignatureKata/blob/master/KeySignature.h#L1: Includes should be within your #ifndef pragmas.
- https://github.com/abrock17/KeySignatureKata/blob/master/KeySignature.h#L21: All parameters which are non-modifiable should be marked as const &.
- https://github.com/abrock17/KeySignatureKata/blob/master/KeySignature.h#L30: static const values should be defined in the header, but initialized in the cpp.
- https://github.com/abrock17/KeySignatureKata/blob/master/KeySignature.cpp#L49: Single character variable names should be given meaningful names.
- https://github.com/abrock17/KeySignatureKata/blob/master/tests/KeySignatureTest.cpp#L5: Missing "Then" in your test name (to be consistent with your other test names).
- Made the appropriate methods const