As a result of this, coverage isn't 100.


On Thu, May 1, 2014 at 3:20 PM, Paul Kehrer <notifications@github.com>wrote:

> In cryptography/hazmat/backends/openssl/backend.py:
>
> > +        data_to_sign = self._hash_ctx.finalize()
> > +        self._hash_ctx = None
> > +        sig_buf_len = self._backend._lib.DSA_size(self._dsa_cdata)
> > +        sig_buf = self._backend._ffi.new("unsigned char[]", sig_buf_len)
> > +        buflen = self._backend._ffi.new("unsigned int *")
> > +
> > +        # The first parameter passed to DSA_sign is unused by OpenSSL but
> > +        # must be an integer.
> > +        res = self._backend._lib.DSA_sign(
> > +            0, data_to_sign, len(data_to_sign), sig_buf,
> > +            buflen, self._dsa_cdata)
> > +
> > +        if res != 1:
> > +            errors = self._backend._consume_errors()
> > +            assert errors
> > +            raise InvalidSignature
>
> asdfasdf it sure isn't. This should just be an assert.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pyca/cryptography/pull/991/files#r12210860>
> .
>



-- 
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084