[WIP] 1.2.0-RC1

this is a strange BC break @dbu
it seems the code was previously wrong, not sure why it still worked before.