first commit
change parameter types