Don't swap '[User Set]' into welcome emails when accounts are created in the Dashboard

This is incorrect behavior, because when the emails are created when is_admin(),
the password is not set by the user.

The is_admin() exception was mistakenly removed in r6439.

Fixes #5466

Props SergeyBiryukov

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8137 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Use closest() instead of parent() to hide unfavorited activity item

Ancestor-crawling makes for inflexible javascript, which makes for sad developers.

Fixes #5467

Props hnla

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8138 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Check the right capabilities are used in the BP_Admin class

The introduction of the link "About BuddyPress" within the WP Admin Bar revealed that in multisite configurations, some administration menus were accessible to regular administrators when they should be restricted to the Super Administrator.
Now, the capacity used in these menus will be adapted to the configuration in which BuddyPress evolves using a "network" capacity when necessary.

props johnjamesjacoby, boonebgorges, imath

Fixes #5465

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8140 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
bp-legacy: Remove charset attribute for <script> call.

This is invalid HTML.

Fixes #5366

Props henry.wright

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8141 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Replace wp_parse_args() with bp_parse_args() for all template loops.

bp_parse_args() allows developers to filter the template arguments
before the loop is rendered.  This will allow for greater
flexibility to manipulate template loops in plugins.

See #5306

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8142 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
POT, generated from r8142

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8143 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Prevent a regular administrator to change the profile of a super administrator

In Multisite configs where BuddyPress is not network activated, we need to make sure a regular admin cannot edit the BuddyPress profile of a Super Admin.

props boonebgorges, imath

Fixes #5463

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8145 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Ensure BuddyPress tools feedback messages are displayed in multisite configs

Fixes #5470

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8146 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Exclude members marked as spam from Group Admin autocomplete results

In Groups /wp-admin UI, the autocomplete feature to add a new member to the group need to exclude spammed users.

props DJPaul

Fixes #5359

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8147 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Make sure Signups Management is restricted to Super Admin when BuddyPress is not network activated

On a multisite config, when BuddyPress is not network activated, we need to prevent a regular admin to access to the signups management screens as the different actions requires Super Admin privileges.

See #5374

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8148 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
In wp-admin/profile, be consistent with front-end when BuddyPress is not network activated

In this specific config, on front-end, the regular Admin :
- can edit members profile,
- cannot edit a Super Admin profile,
- cannot mark as spam a user.

We need to make sure, this is also the case in the wp-admin/profile screens.

See #5367

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8149 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add AJAX-powered pagination for group membership requests admin pages

Fixes #5440

Props dcavins

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8150 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Pinking shears

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8151 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add admin menus to manage signups only if they are allowed

Before adding the menu to manage signups we must be sure the site allows people to register.

See #5374

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8152 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add test for sort_order and order_by date in notifications component.

See #5452

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8153 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Improve inline docs for BP_Notifications_Notification::get()

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8154 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Don't reproduce the activity-form-loop on an AJAX request

Fixes #5329

Props imath

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8155 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Run stripslashes filter on activity strings earlier than priority 10

Running stripslashes() on priority 10 caused race conditions with other filters
on the same content. This, in turn, causes conflicts with wptexturize(), which
cannot properly parse certain character combinations due to the incorrect
presence of escaping slashes. This problem exhibited itself most obviously
with the use of guillemet-style quotation marks (the slashes fooled
wptexturize() into thinking that the opening quote was actually the closing
one), but could also occur with other formatting rules.

Because the requirement to stripslashes() is due to BuddyPress's incorrect
escaping of much input content, we work around the race condition by running
stripslashes_deep() earlier than priority 10. This ensures that plugins hooking
to these filters with the default priority can expect properly formatted and
sanitized content. See #2776.

Props chouf1, imath, needle

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8156 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Improve validation and documentation for groups_create_group() and BP_Groups_Group::save()

Fixes #5214

Props r-a-y

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8157 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Don't register the bp-themes themes directory if bp-default is found elsewhere in the installation

This will be part of the migration path away from the packaged version of
bp-default. bp-default will be added to the wordpress.org theme repository with
a higher version number, prompting an upgrade that will result in an
installation into the standard WP themes directory. Once that happens, most
installations will no longer be reliant on the version of bp-default packaged
with BuddyPress.

See #5212

Props DJPaul

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8158 cdf35c40-ae34-48e0-9cc9-0c9da1808c22