Removes hash after the url when clicking Meta Data

Removes that hash appended to the URL when clicking Meta Data in post settings.

Closes #4386

When clicking 'Meta Data' the click event appends a # to the URL. I replaced the a with a button element so that won't happen anymore. The button has a type attribute because it will try and submit the form without it. Added text-align: left to the navlist button because the button centers it's content by default.


Dude, wha? Class beats element. Are you sure the problem isn't just that he
hasn't put the class on the button yet?
On Nov 5, 2014 7:23 AM, "Paul Davis" <notifications@github.com> wrote:

> In core/client/assets/sass/patterns/navlist.scss:
>
> > @@ -43,6 +43,10 @@
> >          border-bottom: 1px solid #E0DFD7;
> >      }
> >
> > +    button {
> > +        text-align: left;
> > +    }
> > +
>
> If .nav-list-item had the style, but button has a conflicting inherited
> style, it would use the inherited style.
> By having .nav-list-item button, it is forced to use the desired style by
> virtue of having a heavier selector.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TryGhost/Ghost/pull/4405/files#r19875216>.
>