Removed unneeded const_cast from TrackAssociatorByHits

Removed unneeded const_casts and avoided copying std::vectors. The
const_casts had been spotted by the static analyzer.
Merge pull request #4173 from Dr15Jones/removeUnneededConstCastTrackAssociatorByHits

Removed unneeded const_cast from TrackAssociatorByHits