I like 'Custom' better in case we want to further extend it.

Carlos A. Munoz
Software Engineering Supervisor
Engineering - Internationalization
Red Hat

On Mon 03 Feb 2014 10:02:21 AM EST, Sean Flanigan wrote:
> In
> zanata-war/src/main/java/org/zanata/security/negotiation/NegotiationAuthenticator.java:
>
> > +package org.zanata.security.negotiation;
> > +
> > +import org.apache.catalina.connector.Request;
> > +import org.apache.catalina.deploy.LoginConfig;
> > +
> > +import javax.servlet.http.HttpServletResponse;
> > +import java.io.IOException;
> > +
> > +/**
> > + * Override JBoss' Negotiation authenticator to customize some of its
> > + * functionality.
> > + *
> > + * @author Carlos Munoz <a
> > + *         href="mailto:camunoz@redhat.com">camunoz@redhat.com</a>
> > + */
> > +public class NegotiationAuthenticator extends
>
> A lot of style tools will warn about a class with the same name as its
> superclass. (eg in some circumstances you might see the classname
> without the package name, so it probably is better for classnames to
> be unambiguous.) How about HTMLNegotiationAuthenticator? Or simply
> CustomNegotiationAuthenticator?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zanata/zanata-server/pull/352/files#r9372655>.
>