minor code tidy ups
minor code tidy ups - in don't pass  as ref per std we have been moving to
minor code tidy ups - remove unused lines, don't pass ids as ref as not
std
CRM-14197 towards refactoring form specific actions back onto the form as part of
figuring out how to set membership entity id on line item (preliminary simplication
Move the create CMS user onto the form function
move create CMS user back onto form & encourage passing of membership id to renewmembership function
rename parameter from contributionType to financialType
remove unused paramter deductible mode
pass isTest & lineitems into processContribution
further refactoring to pass more params into smaller functions to make fixing membership line items doable
declare used variables & comment fix
clarify creation of creating a separate membership contribution
param fix & clarify object to pass to updateRecurmembership fn
declare membershipContributionID & use that
remove  param
don't check for empty on  - would have had an error
remove unrequired param
set membershipContribution directly as required
remove minor code duplication, ensure  set to form value
minor cleanups