Hi Ulrik,

Sorry for not catching that.  I have not had a chance to test it since merging the code.

I am sure that it was not Jason’s intent to break backwards compatibility.

Mark


From: Ulrik Kofoed Pedersen [mailto:notifications@github.com]
Sent: Monday, May 19, 2014 2:52 AM
To: areaDetector/ADCore
Cc: Mark Rivers
Subject: Re: [ADCore] Requesting storage of an NDArray via Attribute (#18)


In ADApp/pluginSrc/NDPluginFile.cpp:

> @@ -414,6 +415,45 @@ asynStatus NDPluginFile::doCapture(int capture)

>      return(status);

>  }

>

> +

> +/** Decide if a previous plugin has requested that this plugin stores the array data

> + */

> +bool NDPluginFile::attrIsStorageRequested ( NDAttributeList* pAttrList ) {

> +

> +    NDAttribute *attribute;

> +    attribute = pAttrList->find ( FILEPLUGIN_WRITEFILE );

> +

> +    if ( NULL == attribute ) {

> +

> +         asynPrint ( this->pasynUserSelf, ASYN_TRACE_FLOW, "%s:%s: FILEPLUGIN_WRITEFILE attribute unavailable.\n", driverName, __func__ );

> +        return false;

Can we return true here instead? That would allow IOCs which don't define any NDAttributes to continue to work.

—
Reply to this email directly or view it on GitHub<https://github.com/areaDetector/ADCore/pull/18/files#r12782598>.