Unit tests: make sure the user is a member of the group before promoting him

WordPress changeset 30400 introduced {{{STRICT_ALL_TABLES}}} in WPDB and revealed a trouble in {{{BP_Tests_Group_Cache->test_groups_get_group_admins_cache}}}. As the user was directly promoted as an admin of the group without being first added as a member, a WordPress database error was making this test fail.
The ticket will remain open in case we find some other notices errors when we use WPDB.

See #6036

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9156 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Remove all links in titles of directory and single item pages

Since BuddyPress 1.7, to display the "Create" buttons (Blogs & Groups component) and links to the single item landing pages at a similar place to BP-Default, BP Theme Compat was adding links into the title of the WordPress post object. For 2.2, team has decided to remove all these links and find a better placement for them before the end of the dev-cycle.

See #6008

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9157 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
When cropping an avatar, make sure the "w" crop parameter does not interfere with WP_Query

In the different edit-avatar templates, cropping forms include a field named "w". When posted, this particular posted variable is interpreted as the week parameter of the main WordPress query. This commit introduces a new function bp_core_avatar_reset_query() that will make sure the week parameter is not set when an avatar is being cropped.

props boonebgorges, DJPaul

Fixes #5999

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9158 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Make sure template notices are displayed in twentyfifteen theme

props hnla

Fixes #6000

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9159 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Make sure the filter  'bp_activity_custom_update'  defaults to false

Fixes #6021

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9160 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Improvements to the messages thread interface.

* Introduce noscript support for bulk actions.
* Revise structure and markup to better match the Notifications table.
* Add "Read/Unread" and "Delete" links for each message thread.
* Remove unnecessary "Select Read/Unread" dropdown.
* Introduce a number of new template functions in support of the new interface.

Props lakrisgubben.
See #6005.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9161 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
RTL styles for new messages interface.

See [9161], #6005.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9162 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Include message in email notification of private group membership request.

Fixes #5885.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9163 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Improve some docblocks in bp-messages-classes.php.

Props slaFFik.
See #5193.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9164 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add some actions and filters to `BP_Messages_Thread`.

Props slaFFik.
See #5193.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9165 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Fix spacing issue introduced in [9165].

Props tw2113.
See #5193.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9166 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Settings: rename the member/settings subnav tab name from "Profile" to "Profile Visibility".

The new name clarifies what the purpose of this subnav screen is; that is, to manage profile fields' visibility.

Fixes #5599, props tharsheblows

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9167 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Core, Activity: change the Activity table's `primary_link` column from `varchar(255)` to `text`.

This change will avoid unintended truncation for long URLs. This can be a problem for links
built from slugs written in double-byte languages, or for letters that have been URL encoded.

We've tried previously to fix this, in r5966. Better luck this time. :)

Fixes #5890, props tharsheblows

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9168 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Ensure that 'count_total' is available throughout `bp_has_activities()` loop.

Props tharsheblows.
Fixes #5915.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9169 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Assemble group notification hooks dynamically.

This makes them easier to document using WP's filter documentation standards.

Props Mamaduka.
See #5970.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9170 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Core: admin notice functions now support a "type".

The type parameter is used to set a CSS class when the notices are
rendered in wp-admin. It defaults to “updated”, which is the same as
the previous behaviour, which is visually styled as the box with the
green border.

Fixes #6041

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9171 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Core: render the permalink nag an error message

Previously, it’s been rendering with a green border which I think helps
make people blind to the fact that we’re asking for action to be taken
(based on real-life user testing).

See #6041

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9172 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Generate friend initiation hook dynamically.

This makes it easier to document per WP standards.

Props tw2113.
See #5942.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9173 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add hook documentation in bp-friends-functions.php.

Props tw2113.
See #5942.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9174 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add hook documentation in bp-friends-notifications.php.

Props tw2113.
See #5942.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@9175 cdf35c40-ae34-48e0-9cc9-0c9da1808c22