Make LogLock immunde to log level changes and also log file, line num and func

By renaming LogLock to log_lock and adding a macro LogLock, and directly
calling DisplayLogComponentLevel from within log_lock we both make LogLock
no longer at risk from changing log level, AND we also make the log message
appear to originate from the caller of LogLock (this will help debug a lot).

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Make state_lock.c safe from log level changes

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Use display_buffer for clientid related string creation

Also, make sure all the related strings are valid when created independently
from a LogXXX macro which might cause problems if log level changes in
mid-stream.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Have clientid hold a gsh_client reference

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Respond to gsh_client_removeclient better depending on reason for failure

Particularly distinguish between not found and busy.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Add hostip_str to client (host addre w/o port)

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Remove cid_client_addr

Use the gsh_client for enerything now.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Add display_sockaddr function using display_buffer

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Convert rest of SAL display functions to use display_buffer

Also assure that if a string is constructed inside an if (isDebug())
construct, that we keep track of the validity of the string so that if the
log level increases, we don't then print garbage because the string
construction was skipped earlier.

Also, most places where a pointer to a SAL type is printed with %p,
display the referenced object instead.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>
Remove redundant test for STATE_TYPE_SHARE in open4_do_open

When we looked for a state with the same owner, we only considered states
of type STATE_TYPE_SHARE so it is redundant to later test if the file_state
which was found is of type STATE_TYPE_SHARE.

Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com>