FCP API "RandomName": Remove support for "type" option
- This allowed the generation of nicknames which were not even valid in terms of Identity.isNicknameValid(). It would be impossible to use such nicknames with WOT.
- The reason is that the option did allow the generation of nicknames which use spaces or non-breakable spaces - which we both don't consider as valid in nicknames
- Notice: Making spaces valid is NOT an option since this would break compatibility with newsreaders for example. We want nicknames to be newsreader compatible though because they are very suitable as UI for things such as Freetalk. (Remember: You can generate a valid E-Mail address with something like "nickname@encoded-identity-id.freetalk")
Fix random nickname generation from returning invalid nicknames:
- This fixes issue https://bugs.freenetproject.org/view.php?id=6148
- Also reduces visibility of function not used anywhere else.
- Also add an unit test so it doesn't happen again.