working on url function