remove deprecation warning

This deprecation was released in 4.1.0 and can be removed for 4.2.0,
deprecation message / handling is no longer necessary.
we never call url_for with a block, so rm
_recall should be set to a hash or not set

Then we can avoid nil checks
Merge pull request #15100 from eileencodes/remove-deprecation-warning-no-longer-needed

remove deprecation warning
begin refactoring delete_records method

Refactor by creating two methods delete_all_records and delete_records
to be called by delete_all and delete (or destroy) respectively.
This reduces the number of conditionals required to handle _how_
records get deleted.

The new delete_count method handles how scope is applied to which
delete action.

A delete_all_records method also has to be called in has_many_through
association because of how the methods are chained. This will be
refactored later on.
remove need for :all symbol

Refactor delete_count method to only handle delete_all or nullify/nil cases
and not destroy and switch to if/else rather than case statement. This
refactoring allows removal of :all symbol usage.
rename delete_all_records to delete_or_nullify_all_records

Rename delete_all_records because this name better describes
what the method is doing. We can then remove :all from the
hm:t version and pull out the unoptimized call to load_target
in delete_records and pass it directly.
remove count var

this change was unneccsary as nothing was gained from it