not other than it's no longer a span


On Sat, Jan 11, 2014 at 9:19 PM, Thomas Wilburn <notifications@github.com>wrote:

> In js/sessions.js:
>
> > @@ -22,31 +23,37 @@ define([
> >      var current = editor.getSession();
> >      tabContainer.innerHTML = "";
> >      tabs.forEach(function(tab, index) {
> > -      var span = document.createElement("span");
> > -      span.setAttribute("draggable", true);
> > -      span.setAttribute("command", "session:raise-tab");
> > -      span.setAttribute("argument", index);
> > -      span.setAttribute("title", tab.fileName);
> > -      span.className = "tab";
> > +      var tabEl = document.createElement("a");
>
> Petty as it may be, I kind of hate the name tabEl. It sounds like
> Superman's brother. Is there a good reason why span wasn't sufficient?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/thomaswilburn/Caret/pull/124/files#r8812624>
> .
>