This change will make jpegparser.c not compile able. Because you did not include vaapitypes.h in Jpegparser.c, it can’t find N_ELEMENTS definition.
If you can pass compile in your machine, maybe you use an old header file. You did not clear the file in your install directory.

How about create cutils.h.
Move all c related utils to it.




From: pinxiong [mailto:notifications@github.com]
Sent: Thursday, May 8, 2014 10:30 AM
To: 01org/libyami
Cc: Xu, Guangxin
Subject: Re: [libyami] update data type (#17)


In common/vaapitypes.h:

> @@ -83,4 +83,7 @@ typedef enum {

>        className(const className&); \

>        className & operator=(const className&); \

>

> +#define N_ELEMENTS(array) \
In terms of the issue of the macro N_ELEMENTS(array) , I asked Halley, he told me I can add it in vaapitypes.h file, if not better solution. If you have more better solution, welcome to your suggestion. From: Xu Guangxin [mailto:notifications@github.com] Sent: Thursday, May 08, 2014 9:55 AM To: 01org/libyami Cc: Xiong, Pin Subject: Re: [libyami] update data type (#17<https://github.com/01org/libyami/pull/17>) In common/vaapitypes.h:
@@ -83,4 +83,7 @@ typedef enum { className(const className&); \ className & operator=(const className&); \ +#define N_ELEMENTS(array) \
not good, codecparsers/jpegparser.c is not compile-able. Since it's not include vaapitypes.h. vaapitypes.h is only for vaapi related things. we'd better not make codecparser depends on it. — Reply to this email directly or view it on GitHub<https://github.com/01org/libyami/pull/17/files#r12412865>.

—
Reply to this email directly or view it on GitHub<https://github.com/01org/libyami/pull/17/files#r12413435>.