OK – the pull requests were only to give people an idea of status at a point in time (and initially to remind people of the DB API syntax changes)

 

This was added in my local branch for ease – and will be pulled out before the actual pull request that gets merged. 

You’ll also note in a couple of places I’ve added markers for TODO’s.

 

I’m thinking it would be better to have sent a DIFF/Patch file to the mailing list for feedback, as where I was expecting people to use it to track status and give high-level feedback, you’ve actually done more then I was expecting (which is *great*, but where I fixed the name of variables $result=db_query() to $t_result (which I believe you/atrol commented on), I’ve now got dregad/rombert stating issues with the branch because they rename variables to follow our naming scheme :).

 

Anyway, I’ve got 12 hours to work on this today.

 

 

 

From: Victor Boctor [mailto:notifications@github.com] 
Sent: 18 April 2014 04:15
To: mantisbt/mantisbt
Cc: grangeway
Subject: Re: [mantisbt] Mantis 2.0 - Database Layer Patch (#162)

 

In tests/bootstrap.php:

> @@ -22,7 +22,7 @@
>   * @global string $GLOBALS['MANTIS_TESTSUITE_SOAP_HOST']
>   * @name MANTIS_TESTSUITE_SOAP_HOST
>   */
> -$GLOBALS['MANTIS_TESTSUITE_SOAP_HOST'] = 'http://localhost/mantisbt/api/soap/mantisconnect.php?wsdl';
> +$GLOBALS['MANTIS_TESTSUITE_SOAP_HOST'] = 'http://localhost/api/soap/mantisconnect.php?wsdl';

Is it intentional that you checked in the rename of this file?

—
Reply to this email directly or view it on GitHub <https://github.com/mantisbt/mantisbt/pull/162/files#r11762824> .