write proper test