Revert "Attach persistent disk before deleting vm when recreating the vm"

This reverts commit 28dc5752e5d290db1f11ed2b502f9ccae6cd28a8.

Signed-off-by: Phan Le <ple@pivotal.io>

Conflicts:
	bosh-director/lib/bosh/director/cloudcheck_helper.rb
	bosh-director/spec/unit/cloudcheck_helper_spec.rb
Revert "Do not have to check for values as they are alway there from default values"

This reverts commit fa1d55040e7abf818240a9d02e73e11f4a8497a9.
Remove micro_discover_ip from vsphere-cpi-release

Signed-off-by: Maria Shaldibina <mshaldibina@pivotal.io>
Added microbosh defaults for aws http_read_timeout & http_wire_trace

Signed-off-by: Phan Le <ple@pivotal.io>
Fixed ReleaseChangePromoter.promote to not return the sha with a line break

[#81219724]

Signed-off-by: Phan Le <ple@pivotal.io>
Fix requirements test to no longer expect logger.info to succeed

Signed-off-by: Zachary Auerbach <zauerbach@pivotal.io>
Switched to MonoLogger in cases that obviously weren't multithreaded

[#81611698]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Removed unnecessary nats initialization from the EM thread startup.

[#82054334]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Added integration test for git commands in ci:promote

- Fixed several git ci:promote bugs

[#81732606]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Adding final release for build 2765
Adds log buffering

- Prints the buffered logs when a test fails
- Allows checking the log_string for logged messages

[#81612110]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Adds log buffering to bosh-monitor

[#81612110]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Add cpi binary to bosh_openstack_cpi

Signed-off-by: Maria Shaldibina <mshaldibina@pivotal.io>
Namespace BufferedLogger to avoid a global 'logger'

[#81612110]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Switch bosh_common to use Logging::Logger instead of Logger

[#81611698]

Signed-off-by: Michael Maximilien <maximilien@acm.org>
Switch bosh-dev to use Logging instead of MonoLogger

[#81611698]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Switch bosh-monitor to use Logging instead of MonoLogger

[#81611698]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Switch bosh-director to use Logging.logger instead of Logger

- Added BufferedLogger to print logs on test errors
- Removed EventLog::CustomLogger in favor of a formatted Logging::Logger

[#81611698]

Signed-off-by: Karl Isenberg <kisenberg@pivotal.io>
Switch bosh_cpi to use Logging::Logger instead of Logger

[#81611698]

Signed-off-by: Michael Maximilien <maximilien@acm.org>
Bump Gemfile.lock with logger gem dependencies

[#81611698]

Signed-off-by: Michael Maximilien <maximilien@acm.org>