Update `bp_is_group_admin_screen()` to use `bp_is_group_admin_screen()`, and add phpdoc block.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8825 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
`bp_is_group_admin_screen()` returns bool, not string.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8826 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Do not process `BP_Group_Extension::setup_access_settings()` if no group ID is available.

If no group ID is available, the `BP_Group_Extension::setup_access_settings()`
method should not do its checks.  This is to avoid running DB queries
unnecessarily.  (See #4785.)

Fixes #5812.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8827 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
bp-legacy: Fix 'Maximum Execution Time' fatal error when attempting to reply to an activity item.

Changes in r8708 caused an infinite loop to occur while manually
determining the activity comment's depth.  This is due to the type casting
in r8708.

To fix this in bp-legacy, we also type cast the various item IDs to prevent
the infinite loop from occurring.

Fixes #5811.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8828 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add support for disabling pagination in BP_Groups_Group::get() by passing per_page=-1

Also adds supporting unit tests.

Fixes #5477

Props dcavins

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8829 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Fix `bp_is_current_component_core()` to reference BP core components.

`bp_is_current_component_core()` is a function that is meant to check
whether the current component is a BP bundled core component.  This is done
by grabbing `bp_get_option( 'bp-active-components' )`, which is supposed to
hold only BP core components.  However, if a plugin manually saves its
component in the `'bp-active-components'` DB option, our function will
now check this 3rd-party component as well, which is incorrect.

To address this issue, this commit introduces `bp_core_get_components()`,
which is a hardcoded array of BP core components, and references this
function in `bp_is_current_component_core()`.  This ensures that only
BP core components are checked.

See #5552.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8830 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Rename `bp_core_get_components()` to `bp_core_get_packaged_component_ids()`.

Ambiguous function names suck.

Props johnjamesjacoby.

See r8830.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8831 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Update `$bp` global touches with calls to `buddypress()` in `bp-groups-activity.php`.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8832 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
POT, generated from r8832

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8833 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Add mercime to contributor list in readme

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8920 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Messages: don't make links in message excerpts clickable.

When a user is on the inbox screen viewing the list of inbox messages, clicking on the excerpt usually takes them to the message thread conversation page where they can read the full message content. If the excerpt part of the full message content happens to have a link in it, the user could end up on some external website after clicking the excerpt link (which 99% of the time takes them to the full message content).

This change removes `make_clickable` from operating on the message excerpt, fixing this problem.

Fixes #5368, props tw2113

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8921 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Do not interfere with WordPress sign-up process when the user is created from the blog or the network administration.

On multisite config, make sure the activation email and the welcome email generated by WordPress are not modified by BuddyPress if the user was created from the User Administration panel. In this case, user needs to receive the built in activation link and/or the login and password generated by WordPress.

Props godavid33, r-a-y

Fixes #5789

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8922 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
POT, generated from r8922

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8923 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Update 2.1 credits list

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8924 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
POT, generated from r8924

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8925 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Templates: fix theme compatibility with form label widths.

Fixes #5804, props mercime and thanks to wolfhoundjesse for the original patch.

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8926 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Templates: fix invalid HTML markup on step 2 of the "Create Group" form.

Unordered lists were made children of respective label elements; this change moves the lists to after the label element.

Fixes #5816, props mercime

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8927 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Make sure BP_User_Query returns correct results when search term contains the Ampersand character

1. Search terms containing this character was problematic as the "&" is a query var delimiter used in {{{bp_legacy_theme_ajax_querystring()}}} to build the ajax querystring

2. When a xProfile field is saved, the value is sanitized using the {{{xprofile_filter_kses()}}} filter which is converting "&" to "&amp;" before inserting the value in database.

Urlencoding the search terms in {{{bp_legacy_theme_ajax_querystring()}}} and applying {{{wp_kses_normalize_entities()}}} to search terms in {{{BP_User_Query}}} & in {{{bp_xprofile_bp_user_query_search()}}} make sure the correct results are returned to the user.

Fixes #5694

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8928 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Make sure the updated activity after a post update is consistent with the initial activity.

In Blogs component, when recording a new_blog_post" update, {{{bp_activity_thumbnail_content_images()}}} and {{{bp_create_excerpt()}}} are used to build the content of the activity. After a updating the post from the dashboard, {{{bp_blogs_update_post()}}} was simply updating the activity with the entire post content.

{{{bp_blogs_update_post()}}} is now using the same functions than {{{bp_blogs_record_activity()}}} to update the content of the activity.

Fixes #5792

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8929 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
POT, generated from r8929

git-svn-id: https://buddypress.svn.wordpress.org/trunk@8930 cdf35c40-ae34-48e0-9cc9-0c9da1808c22