utils/check_patch.py: Remove Makefile from checks

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
frontend/tko/rpc_interface.py: Remove duplicate function

On commit c2cf6683, the method get_test_labels was
added, when there was already such a method with the
exact same implementation. Let's get rid of the newest.

CC: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
installation_support/setup.py: Get rid of package_data

This function is not really necessary, besides, it
depends on other functions that don't exist (bug).

CC: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
client.net.net_utils: Fix some problems found by pylint

1) Fix undefined client_utils reference.
2) Use a less generic ImportError catchall.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
server/hosts/factory.py: Disabling undefined variable pylint error

In this particular case, the missing variables are being
injected in the code namespace. So, in order to silence
pylint (and the Pydev code analyzer), add the appropriate
comments and tags.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
database_legacy/autotest-upgrade-db: Fixing another rename mistake

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
frontend.shared.resource_lib: Ignore false negatives from pylint

Here entry_class is callable by the time it is used, due
to some hackery that is probably too hard to fix right
now. So make pylint ignore the error, so we have more
useful pylint reports.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
run_pylint: Ignore error I0011 on quiet runs

For quiet runs, telling that we're ignoring some false
negatives is not really necessary.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
base_job: Ignore pylint warning

In this particular case, the unittest overrides the
mentioned functions with the purpose of mocking it,
so it's OK it is there. Therefore, taking another
step for a clean pylint quiet run, silence those
errors by appending the appropriate comments.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
tko/nightly.py: Remove irrelevant file

This file was added upstream by mistake, and it was
never supposed to work because it lacked one library
that was yet another database wrapper. Let's just
get rid of it.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
pylint: Disable some E0611 false positives

Autotest uses a site extension mechanism that allows
for extending the functions/API of the framework. But
in upstream code, such extensions won't be there,
reason why it is OK to ignore if they are missing.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
client.shared.test_utils.unittest: Clear E0213 false positive

_deprecate here is used with the very specific purpose
of decorating the unittest comparison methods that are
deprecated so unittest writers don't use them.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
autotest-firewalld-add-service: Supress pylint error on py 2.4

The only way we can catch py 2.4 non compliances is by
running pylint on the entire tree on py 2.4 systems. So,
even though this script would never be used on such
systems, we need them checked, so supress the pylint
error here.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
check_patch.py: Correcting the path of one blacklisted file

This file's path has been recently updated.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
tko: Ressurrect old TKO by re-adding the tko_test_view view

The old TKO web application (a bunch of cgi scripts located
in tko/) was broken with the change to South, since the
tko_test_view view was not contemplated in the datbase
creation schema and migration info.

Fortunately, it is all a matter of adding an sql for the
generation of the view and let autotest-database-turnkey
to process it. We don't need to add it to the Django
models or add it to the migration info, since no django
related code needs to touch it. Users that installed, say,
0.15.0 will have to manually run the sql that creates
the new view as a workaround.

CC: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
check_patch: Compile dependency before full tree check

Make sure we've got the protobuf compiler, and then
always run a build of the protobuf module (this
module is important for some internal code inside tko,
but it is auto generated). If the package is lacking,
let the user know upfront. Point to the right docs
that will help to install all the needed packages.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
utils/check_patch.py: Make script to return failure on check errors

In order to have the checker script to be useful as an
automated test tool, make it return errors when *any*
of the checks return a proper exit code. This wasn't
done before because it took a long time to curate and
check full pylint results (even filtered) and fix
false negatives.

Now hopefully we'll catch more easily silly syntax
errors and py 2.4 non compliances in the autotest
tree.

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
base_utils: properly search for possible site_tests src locations

The original version of this logic (0a0f49e9) looked for src dirs in
site-tests when every reference I have found uses site_tests (w/ an
underscore).

Additionally it seems the current default location for site_tests is
base_autotest + "/tmp/site_tests" as per what I found when triaging
the current client/tests/iosched_bugs make failure so add a "tmp" based
version to the search path as well.

Signed-off-by: Daniel DeFolo <daniel.defolo@hp.com>
install-autotest-server.sh - checkout master branches on client/server tests

Added a call to checkout master branch for both tests subrepos,
this way they will represent latest upstream.

Changes from v1:
 * Also update virt-tests, which is a submodule of the client
   tests submodule

Signed-off-by: Julius Gawlas <julius.gawlas@hp.com>
Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>
cli.job: Disable pylint E0202 false negatives

Signed-off-by: Lucas Meneghel Rodrigues <lmr@redhat.com>