working on loginaction