[Reviewer: Ellie] Craft logging Enhanced Node Troubleshooting 

Added PDLog infrastructure (definition in new header, craft_dcea.h) and PDLogs for http and sip.
It's a "C" file.  Not cpp.  I was trying to keep the facade file as close to the real syslog.h file as possible.
David Collins

Sent from my iPad

On Sep 26, 2014, at 5:58 AM, "Eleanor Merry" <notifications@github.com<mailto:notifications@github.com>> wrote:


In include/syslog_facade.h:

> +
> +#ifndef SYSLOG_PROXY_H__
> +#define SYSLOG_PROXY_H__
> +
> +#include <features.h>
> +#define __need___va_list
> +#include <stdarg.h>
> +
> +// facade to avoid name collision between syslog.h and log.h
> +
> +extern void closelog (void);
> +extern void openlog (__const char *__ident, int __option, int __facility);
> +extern void syslog (int __pri, __const char *__fmt, ...)
> +  __attribute__ ((__format__ (__printf__, 2, 3)));
> +
> +#define PDLOG_PID         0x01    /* log the pid with each message */


Can you use an enum for this instead (it's more of a cpp way of doing it)

—
Reply to this email directly or view it on GitHub<https://github.com/Metaswitch/cpp-common/pull/184/files#r18083660>.