Guys, please also clarify these things in the wiki, because that is our basis for these conventions.

Grigore


________________________________
From: dwightguth [notifications@github.com]
Sent: Tuesday, March 04, 2014 3:36 PM
To: kframework/k
Subject: Re: [k] New parser. Adding NullabilityCheck. (First pull request). (#267)


In src/javasources/KTool/src/org/kframework/parser/concrete2/Parser.java:

> @@ -399,12 +399,12 @@ public int hashCode() {
>      Map<StateReturn.Key,StateReturn> stateReturns = new HashMap<StateReturn.Key,StateReturn>();
>
>      public NonTerminalCall getNtCall(NonTerminalCall.Key key) {
> -            NonTerminalCall value = ntCalls.get(key);
> -            if (value == null) {
> -                    value = new NonTerminalCall(key);
> -                    ntCalls.put(key, value);
> -            }
> -            return value;
> +        NonTerminalCall value = ntCalls.get(key);
> +        if (value == null) {
> +                value = new NonTerminalCall(key);
> +                ntCalls.put(key, value);
> +        }
> +        return value;


I talked with Andrei S and he talked me into this. As long as we only make whitespace changes to 4-space indents, I am okay with what you did here. But I note that the if block is still indented 8 spaces...

—
Reply to this email directly or view it on GitHub<https://github.com/kframework/k/pull/267/files#r10275911>.