work on edit view