Sent from my iPad

> On Feb 27, 2014, at 20:55, slava77 <notifications@github.com> wrote:
> 
> In DataFormats/TrackerRecHit2D/src/BaseTrackerRecHit.cc:
> 
> >  
> >  bool BaseTrackerRecHit::hasPositionAndError() const {
> > -    return (err_.xx() != 0) || (err_.yy() != 0) || (err_.xy() != 0) ||
> > -           (pos_.x()  != 0) || (pos_.y()  != 0) || (pos_.z()  != 0);
> it would make more sense to me to have a flag hasError instead of using expected cases how the BaseTrackerRecHit is created
> "default"-constructed
> 
> btrh = BaseTrackerRecHit(DetId id, GeomDet const * idet, trackerHitRTTI::RTTI rt)
> will return hasPositionAndError true, which is not what we want
> 

ps
i control any place where hits are created. this constructor will disappar soon...
> —
> Reply to this email directly or view it on GitHub.