I like it.


On Thu, May 1, 2014 at 7:01 PM, Zachary Belzer <notifications@github.com>wrote:

> In recipes/wal-e.rb:
>
> > @@ -26,16 +31,19 @@
> >    end
> >
> >    #install packages
> > -  node['postgresql']['wal_e']['packages'].each do |pkg|
> > -    Chef::Log.debug("Install #{pkg} for wal-e recipe")
> > -    package pkg
> > +  unless node['postgresql']['wal_e']['packages'].nil?
> > +    node['postgresql']['wal_e']['packages'].each do |pkg|
>
> Just poking my nose in here, but I usually like Array(node['postgresql']['wal_e']['packages']).each
> ...
>
> 1.9.3-p484 :001 > Array(nil)
>  => []1.9.3-p484 :002 > Array([])
>  => []1.9.3-p484 :003 > Array([:foo])
>  => [:foo]
>
> Carry on...
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/clearstorydata/chef-postgresql/pull/6/files#r12216901>
> .
>