Yes, but then again this service already exists in Eclipse, so we do not
have to reference any sort of editors. :)


On Thu, Jan 30, 2014 at 5:14 PM, James Nelson <notifications@github.com>wrote:

> In
> com.github.sdbg.debug.ui/src/com/github/sdbg/debug/ui/internal/presentation/SDBGDebugModelPresentation.java:
>
> > @@ -184,8 +142,6 @@ public String getEditorId(IEditorInput input, Object element) {
> >        } catch (PartInitException e) {
> >
> >        }
> > -
> > -      return JavaUI.ID_CU_EDITOR;
>
> I actually put ID_CU_EDITOR in under a different PR, but didn't actually
> test it. I think though, that you are right that we should not tie directly
> into java stuff here, and should instead do any language-specific code
> behind a service interface so, if needed, coffeescript, closure and friends
> can have their own service to point to their own editors / language
> features.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/sdbg/sdbg/pull/1/files#r9308159>
> .
>