exit script if any command fails with error code

This setting is definitely best practice for scripting bash.
HOWEVER, unlike #2 this is not a simple safety rail.  It
may be that merging this causes the script to fail because
there are unaccounted errors.