Variant: eliminate gq and pl special getters

Users should use the generic API for all fields. No reason to have
specialized getters for a few ones.

fixes #183
Works for me.


On Fri, Aug 15, 2014 at 12:05 PM, MauricioCarneiro <notifications@github.com
> wrote:

> In gamgee/variant.h:
>
> >
> >    // generic individual field getters (a.k.a "format fields")
> >    IndividualField<IndividualFieldValue<int32_t>> integer_individual_field(const std::string& tag) const;    ///< returns a random access object with all the values in a give individual field tag in integer format for all samples contiguous in memory.  @warning Only int8_t GT fields have been tested. @warning Missing GT fields are untested. @warning creates a new object but makes no copies of the underlying values.
> >    IndividualField<IndividualFieldValue<float>> float_individual_field(const std::string& tag) const;        ///< returns a random access object with all the values in a give individual field tag in float format for all samples contiguous in memory.  @warning Only int8_t GT fields have been tested. @warning Missing GT fields are untested. @warning creates a new object but makes no copies of the underlying values.
> >    IndividualField<IndividualFieldValue<std::string>> string_individual_field(const std::string& tag) const; ///< returns a random access object with all the values in a give individual field tag in string format for all samples contiguous in memory. @warning Only int8_t GT fields have been tested. @warning Missing GT fields are untested. @warning creates a new object but makes no copies of the underlying values.
> > +  IndividualField<Genotype> genotypes() const;                                                              ///< returns a random access object with all the values in a given GT tag for all samples contiguous in memory. @warning Only int8_t GT fields have been tested. @warning Missing GT fields are untested. @warning creates a new object but makes no copies of the underlying values.
>
> good point. I just got rid of the "specific getters" section, so I felt
> like this one fit better with these guys and I should actually take the
> word "generic" out of that comment. What do you think?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/broadinstitute/gamgee/pull/184/files#r16299990>.
>