Additional fixes to work with RelEx2Logic

modifying parse-get-words to work with new changes made in https://github.com/opencog/relex/pull/71
No, please don't do that. Fixing a bug by adding another hacky bug just
leads to coding insanity. The correct fix is to change relex2logic to call
the correct function. If it needs them in order, then call the in-order
version.

The original version never guaranteed word order. The fact that relex2logic
accidentally assumed they were in order, and depended  on this undocumented
side-effect, is a bug.  Since we just found the bug, the correct answer is
to fix the bug...



On 15 June 2014 21:41, William Ma <notifications@github.com> wrote:

> In opencog/nlp/scm/nlp-utils.scm:
>
> > @@ -19,8 +19,9 @@
> >  ; -- document-get-sentences Get senteces in document.
> >  ; -- sentence-get-parses    Get parses of a sentence.
> >  ; -- sent-list-get-parses   Get parses of a list of sentences.
> > -; -- parse-get-words        Get all words occuring in a parse.
> > +; -- parse-get-words        Get all words occuring in a parse in order.
>
> Hello Linas,
>
> I double checked the usage of parse-get-words. I believe the usage in both
> relex-to-logic.scm and disjunct-list.scm require the correct word order.
>
> I believe a better solution would be to create "parse-get-words-quick" so
> not to break existing functionality.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opencog/opencog/pull/857/files#r13790717>.
>