I sent this pull request: https://github.com/ficoos/cpopen/pull/18

If you rebase your patch on this it should merge cleanly (after changing
your patch).


On Thu, Jan 2, 2014 at 10:46 PM, Nir Soffer <nirsof@gmail.com> wrote:

> I don't think the pull request can be merged with my patch on the bottom -
> I'm sending another patch which should make it easier.
>
>
>
> On Thu, Jan 2, 2014 at 2:28 PM, dankenigsberg <notifications@github.com>wrote:
>
>> In cpopen/cpopen.c:
>>
>> >                          goto fail;
>> >
>> >                  }
>> >              } else if (rv < sizeof(int)) {
>> > -                PyErr_SetString(PyExc_OSError, strerror(childErrno));
>> > +                errno = childErrno;
>>
>> My patch did not make anything worse, it's just perpetuated the usage of
>> uninitialized variable, which I'd rather avoid. I've pushed another version
>> of this branch, with your patch at the bottom - I hope I did not break any
>> github etiquette by doing that.
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/ficoos/cpopen/pull/15/files#r8611260>
>> .
>>
>
>