pacman-db-upgrade: be more verbose

People have mentioned that the silent upgrade to DB version 9 when no
adjustments are needed for directory symlinks is confusion.  Always print
the upgrading message.

Signed-off-by: Allan McRae <allan@archlinux.org>
makepkg: download sources for all architectures when making source package

We validated all sources when making a source package, whether or not they
are included in the tarball.

Signed-off-by: Allan McRae <allan@archlinux.org>
pacman-db-upgrade: set umask 022

This prevents the database from becoming inaccessible for non-root
users when the script was executed with a umask of 027.

Signed-off-by: Peter Wu <peter@lekensteyn.nl>
Signed-off-by: Allan McRae <allan@archlinux.org>
Use correct mode bits for the log file (0000 -> 0644)

Following commit 086bbc5 (Use O_CLOEXEC as much as possible when opening
files), the log file would be created by pacman with blank permissions.

Signed-off-by: Allan McRae <allan@archlinux.org>
makepkg: properly correlate checksums for multiple sources

Previously, we used a single boolean value to determine correlation of
sources to checksums. Since the introduction of arch-specific sources,
this is no longer sufficient, as we must ensure that we have checksums
for (potentially) multiple source arrays.

This change inlines the logic of have_sources to build an associative
array of source array names, unsetting them as we discover their
checksums. The error condition then becomes a non-empty correlation
array.

Fixes: https://bugs.archlinux.org/task/43192

Signed-off-by: Allan McRae <allan@archlinux.org>
Improve db upgrade error message

This message is clearer without (another) error prefix.

Signed-off-by: Allan McRae <allan@archlinux.org>
checkupdates: show error when fakeroot is missing

Signed-off-by: Allan McRae <allan@archlinux.org>
checkupdates: include package versions in output

Especially useful now that pacman -Qu will also show the new version.

Signed-off-by: Allan McRae <allan@archlinux.org>
_alpm_delta_dup: free memory on error

Signed-off-by: Allan McRae <allan@archlinux.org>
depmiss_new: free memory on error

Signed-off-by: Allan McRae <allan@archlinux.org>
build_payload: free memory on error

Signed-off-by: Allan McRae <allan@archlinux.org>
Fix memory leak in ALPM_EVENT_OPTDEP_REMOVAL callback

Signed-off-by: Allan McRae <allan@archlinux.org>
pacman/util.c: fix potential memory leak in indentprint
_alpm_dep_dup: free memory on error

Signed-off-by: Allan McRae <allan@archlinux.org>
_alpm_delta_parse: free memory on error

Signed-off-by: Allan McRae <allan@archlinux.org>
_alpm_db_get_pkgcache_hash: check for error when loading pkgcache

Signed-off-by: Allan McRae <allan@archlinux.org>
_alpm_db_new: free memory on error

Signed-off-by: Allan McRae <allan@archlinux.org>
local_db_read: fix memory leak on error

Signed-off-by: Allan McRae <allan@archlinux.org>
_alpm_conflict_dup: fix memory leak on error

Signed-off-by: Allan McRae <allan@archlinux.org>
alpm_dep_from_string: free memory on error

Signed-off-by: Allan McRae <allan@archlinux.org>