made trade controller test pass