Upgrade gwtorm to 1.11

This version of gwtorm contains an important bug-fix that ensures that
"LIMIT ?" is not omitted in generated queries [1]. This can improve the
performance of such queries by a large factor.

[1] https://gerrit-review.googlesource.com/57216

Change-Id: Ibd0d3918629b2901288de6dd2e85489e4503091a
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Buck: Deploy plugin artifacts to Maven Central

Switch deploying Gerrit extension and plugin API from Google storage
bucket to Maven Central.

To simplify the troubleshooting new trace option was added to
underlying python script. When environment variable VERBOSE=1
is set, then the mvn command is printed to stderr:

  VERBOSE=1 buck build api_deploy_oss
Change-Id: I9ebe44ec8aca91aa6b5514f561209e7c50377927
Merge "Buck: Deploy plugin artifacts to Maven Central" into stable-2.9
Fix documentation of how to publish artifacts to Maven Central

The preparations for publishing to the Google Cloud Storage are not
needed anymore.

Change-Id: I306de581fb30fa2bcacfacdc9de29194a5d9793f
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Bash: Deploy plugin archetypes to Maven Central

  ./tools/plugin_archetype_deploy.sh

This script builds and deploys plugin archetypes to Maven Central.

Change-Id: I4fc8e80f0907c2f43cf5f348a0f334c1e86f8db8
Merge "Upgrade gwtorm to 1.11" into stable-2.9
Fix AccountInfo.has_avatar_info() that wrongly always returns true

AccountInfo.has_avatar_info() checks whether the AccountInfo contains
an avatar field. This is currently always true. Set this field on
server side only if an avatar provider is installed.

Change-Id: Ib73bd925d70d5049688ae9a57a058645b2cbda41
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
SideBySide2: Hide reviewed checkbox if not signed in

Users cannot mark a file as reviewed unless they are signed in, as the
server needs the user identity to store the reviewed flag. The checkbox
is hidden on ChangeScreen2 for anonymous users, so hide it in SBS2.

Change-Id: I96605222fab5ab0cb64c157b51dc4ca92ec4732d
SideBySide2: Do not offer 'r' keybinding to anonymous users

Anonymous users cannot mark a file as reviewed, as the server
has no way to track the stored flag. Disable the keybinding
so it does not appear in the help dialog.

Change-Id: I415a24754d1b4b5120b5b40e074ee697cf921b52
Populate CodeReviewCommit before passing to MergeValidators

The onPreMerge method of MergeValidationListener may reasonably
assume that the fields of CodeReviewCommit are populated, for example
that commit.notes() will not NPE. The previous ordering of code in
MergeOp.validateChangeList() made this assumption false.

Change-Id: I9bd9e76bb09a25faf57df7080cdb0c8f878a7471
Update plugin owned capabilities documentation

Mention in first sentence that capabilities can be also used with
UiActions. Also fixes small copy-paste error from UiActions section.

Change-Id: I686e7b40f04216367751b8829295973fa6fa2c09
Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Add missing documentation of changes REST API index endpoint

Change-Id: Ic89a44b772f9e4cd3f3420f3a689e6126e4ebb6b
Recheck change mergeability status on restore

Bug: Issue 2692
Change-Id: I2085218c80b122cc296e03ff43c4a95c4196ba43
Merge "Add missing documentation of changes REST API index endpoint" into stable-2.9
Merge "Populate CodeReviewCommit before passing to MergeValidators" into stable-2.9
Describe in the release documentation how to update versions

Change-Id: If097829f5e7a80871593ed115b3966192254708c
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Minor fixes in release documentation

Change-Id: I3d218019af9331b3bb04eb5871ea30f03e2933c0
(cherry picked from commit 0c104027ccd98436994b49208c615f32cb679392)
Release docs: describe how to upload the WAR to the Google Cloud Storage

Publishing the WAR file is more important than publishing the plugin
artifacts. This is why the section that describes the publishing of
the WAR file should come first.

Change-Id: Ibc0bea4d8a70a1b737f62ff4c9978fb0081d720d
Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>