iommu/omap: Convert to devm_* interfaces

[ Upstream commit f129b3dfb5517c91295da9fe0d2e584d8da25518 ]

Use the various devm_ interfaces to simplify the cleanup in
probe and remove functions.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Signed-off-by: Suman Anna <s-anna@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
iommu/omap: Fix error return paths in omap_iommu_attach()

[ Upstream commit 7ee08b9ef2e942a5477f02a71947b933eb4101d2 ]

There are couple of issues with the error return paths in
omap_iommu_attach():
1. omap_iommu_attach() returns NULL or ERR_PTR in case of error,
   but omap_iommu_attach_dev() only checks for IS_ERR. Thus a NULL
   return value (in case driver_find_device fails) will cause the
   kernel to panic when omap_iommu_attach_dev() dereferences the
   pointer.
2. A try_module_get() failure returns a valid success value as
   returned from iommu_enable().

Both the above issues have been fixed up to return the proper
ERR_PTR.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
iommu/omap: Allow enable/disable even without pdata

[ Upstream commit 90e569c4ca727b59ba8f82a9cd5e2f43462bbc3b ]

When booting with a devicetree, no platform data is provided.
Do not prematurely exit iommu_enable() and iommu_disable() in
such a case.

Note: As OMAP do not yet has a proper reset controller driver,
IOMMUs requiring a reset signal should use pdata-quirks as a
transitional solution.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Signed-off-by: Suman Anna <s-anna@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
Documentation: dt: add OMAP iommu bindings

[ Upstream commit a8689f65de5a8c3e47bf29c2550dfebe0744e077 ]

This patch adds the iommu bindings for all OMAP2+ SoCs. Apart from
the standard bindings used by OMAP peripherals, this patch uses a
'dma-window' (already used by Tegra SMMU) and adds two OMAP custom
bindings - 'ti,#tlb-entries' and 'ti,iommu-bus-err-back'.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
[s-anna@ti.com: split bindings document, add dra7 and bus error back]
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>

Signed-off-by: Dan Murphy <DMurphy@ti.com>
iommu/omap: Add devicetree support

[ Upstream commit 3c92748df9941ff8f5be4655a04812ff4d0c7eeb ]

As OMAP2+ is moving to a full DT boot for all SoC families, commit
7ce93f3 "ARM: OMAP2+: Fix more missing data for omap3.dtsi file"
adds basic DT bits for OMAP3. But the driver is not yet converted,
so this will not work and driver will not be probed. Convert it!

The legacy boot mode is still supported until OMAP3 is converted
to DT-boot only.

Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
[s-anna@ti.com: dev_name adaptation and improved error checking]
Signed-off-by: Suman Anna <s-anna@ti.com>
[tony@atomide.com: Ack for arch/arm/*omap* parts]
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>

Signed-off-by: Dan Murphy <DMurphy@ti.com>
iommu/omap: Enable bus-error back on supported iommus

[ Upstream commit b148d5fb2ef7bd1441e95402effe22b7b34f9a73 ]

The remoteproc MMUs in OMAP4+ SoCs have some additional debug
registers that can give out the PC value in addition to the
MMU fault address. The PC value can be extracted properly only
on the DSP cores, and is not available on the ARM processors
within the IPU sub-systems. Instead, the MMUs have been enhanced
to throw a bus-error response back to the IPU processors.

This functionality is programmable through the MMU_GP_REG register.
The cores are simply stalled if the MMU_GP_REG.BUS_ERR_BACK_EN bit
is not set. When set, a bus-error exception is raised allowing the
processor to handle it as a bus fault and provide additional debug
information. This feature is turned on by default by the driver on
iommus supporting it.

Signed-off-by: Subramaniam Chanderashekarapuram <subramaniam.ca@ti.com>
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
iommu/omap: Allocate archdata on the fly for DT-based devices

[ Upstream commit 07a0203021149140f83e64a9ac5fe7ed09a74afc ]

The OMAP IOMMU driver locates the IOMMU associated to a device using the
IOMMU name stored in the device archdata iommu field. That field is
expected to be populated by platform code and is left unset for DT-based
devices. This results in a crash when the IOMMU driver attaches a domain
to a device.

Fix this by allocating the archdata iommu structure when devices are
added and freeing when they are removed. Devices without an OF node, and
devices without an iommus property in their OF node are ignored. The
iommu name is initialized from the IOMMU device node name.

This should be simplified when removing non-DT support completely from
the IOMMU users as the IOMMU name won't be needed anymore, and the
IOMMU device pointer could then be stored in the archdata iommu field
directly.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
[s-anna@ti.com: updated to use device name instead of OF name]
Signed-off-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>

Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: remove a duplicative test

[ Upstream commit b38313d627e29d7dfc4aed242fc007806a85d3f0 ]

Static checkers complain that testing for both "next" and "!next" is
duplicative.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Balaji T K <balajitk@ti.com>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: Add support for quirky omap3 hsmmc controller

[ Upstream commit 59445b10d08144d870d8340ce25634014bf972d5 ]

When device is booted using devicetree, platforms impacted by Erratum
2.1.1.128 is not detected easily in the mmc driver. This erratum
indicates that the module cannot do multi-block transfers. Platforms
such as LDP which use OMAP3 ES revision prior to ES3.0 are impacted by
this.

Provide a new compatible property "ti,omap3-pre-es3-hsmmc" to allow
driver to determine if driver needs to implement quirks associated
with the specific module version (primarily because the IP revision
information is not sufficient for the same).

Signed-off-by: Nishanth Menon <nm@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Balaji T K <balajitk@ti.com>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: support more DT properties

[ Upstream commit c9ae64db673d5b0bdd6494a59afcc5ed72669932 ]

This should probably be done implicitly through mmc_of_parse(), but that
doesn't play well along with the multi-slot model the hsmmc driver
features. Hence, for now, do it manually. The properties are already
documented in Documentation/devicetree/bindings/mmc/mmc.txt.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Acked-by: Balaji T K <balajitk@ti.com>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: use devm_regulator API

[ Upstream commit f2ddc1dab61018becf4c5e275bb559d96eec8035 ]

Use devm_regulator API, while at it use
devm_regulator_get_optional for optional vmmc_aux supply

Signed-off-by: Balaji T K <balajitk@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Tested-by: Florian Vaussard <florian.vaussard@epfl.ch>
Tested-by: Stefan Roese <sr@denx.de>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: handle vcc and vcc_aux independently

[ Upstream commit 987fd49b894ec964231dfc5b6bbb2bc12e2b56b5 ]

handle vcc and vcc_aux independently to reduce indent.

Signed-off-by: Balaji T K <balajitk@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Tested-by: Florian Vaussard <florian.vaussard@epfl.ch>
Tested-by: Stefan Roese <sr@denx.de>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
regulator: add pbias regulator support

[ Upstream commit 11469e0bb1c5eedd3b489a4b19dbd26c02577674 ]

pbias register controls internal power supply to sd card i/o pads
in most OMAPs (OMAP2-5, DRA7).
Control bits for selecting voltage level and
enabling/disabling are in the same PBIAS register.

Signed-off-by: Balaji T K <balajitk@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Mark Brown <broonie@linaro.org>
Tested-by: Florian Vaussard <florian.vaussard@epfl.ch>
Tested-by: Stefan Roese <sr@denx.de>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: adapt hsmmc to use pbias regulator

[ Upstream commit e99448ff1f738412bbfec595b5e682c1f0a50279 ]

In DT case, PBAIS registers are programmed via regulator,
use regulator APIs to control PBIAS.

Signed-off-by: Balaji T K <balajitk@ti.com>
Tested-by: Florian Vaussard <florian.vaussard@epfl.ch>
Tested-by: Stefan Roese <sr@denx.de>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
ARM: dts: add pbias dt node

[ Upstream commit cd042fe5c1f67a7b60e027802a0784b95c4dee6f ]

Add pbias regulator node as a child of system control
module - syscon.

Signed-off-by: Balaji T K <balajitk@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Tested-by: Florian Vaussard <florian.vaussard@epfl.ch>
Tested-by: Stefan Roese <sr@denx.de>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
ARM: OMAP: enable SYSCON and REGULATOR_PBIAS in omap2plus_defconfig

[ Upstream commit 12a7108787da44381aa2e1bd268231b9ea19b752 ]

Enable REGULATOR_PBIAS needed for SD card on most OMAPs.

Signed-off-by: Balaji T K <balajitk@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Tested-by: Florian Vaussard <florian.vaussard@epfl.ch>
Tested-by: Stefan Roese <sr@denx.de>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: remove pbias workaround

[ Upstream commit 2cf171cb2579e82f3d587e8ea438afb2b78ddff2 ]

remove pbias workaround

Signed-off-by: Balaji T K <balajitk@ti.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Tested-by: Florian Vaussard <florian.vaussard@epfl.ch>
Tested-by: Stefan Roese <sr@denx.de>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: fix return error code for of_get_hsmmc_pdata

[ Upstream commit 19df45bcd7d153b1c7140e7dbe885a55ddcb3449 ]

of_get_hsmmc_pdata returns a pointer, returning NULL is invalid,
return ERR_PTR for error case.

Signed-off-by: Balaji T K <balajitk@ti.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: remove redundant reset done

[ Upstream commit 4ea42235b5a999eff57f38696ae532a6b9377c55 ]

Remove redundant reset done check since omap hwmod layer ensures IP reset.

Signed-off-by: Balaji T K <balajitk@ti.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>
mmc: omap_hsmmc: save clock rate to use in interrupt context

[ Upstream commit 6e3076c27da0ac653dda6503dadd2852c2d0eac1 ]

clk_get_rate throws DEBUG_LOCKS_WARN_ON(in_interrupt()) warning
if called from interrupt context.
use cached clock rate in set_data_timeout, so that
set_data_timeout can be called from interrupt context.

Signed-off-by: Balaji T K <balajitk@ti.com>
Signed-off-by: Chris Ball <chris@printf.net>
Signed-off-by: Dan Murphy <DMurphy@ti.com>