correct! fixed in 4dabfc4.

The one thing this method did is try to convert the input to an int. I 
will add the same check to the __init__ method (we do this in Timeout as 
well).

On 1/29/14, 0:33, Andrey Petrov wrote:
>
> In urllib3/util/retry.py:
>
> > +        """
> > +
> > +        def _should_apply_total():
> > +            # _total_specified here checks whether we should be applying the
> > +            # limit at all.
> > +            return self._total_specified
> > +
> > +        return (
> > +            (_should_apply_total() and self._total_error_count > self.total)
> > +            or self._connect_error_count > max(self.connect, self.total)
> > +            or self._redirect_count > max(self.redirects, self.total)
> > +            or self._read_error_count > max(self.read, self.total))
> > +
> > +
> > +    @classmethod
> > +    def from_int(self, raw_retry):
>
> I don't think we need this. |Retry(x)| is the same as |Retry.from_int(x)|.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/shazow/urllib3/pull/326/files#r9258994>.
>