SlackWebhookAppender 2s batching to prevent spaming slack

good points. fixed. thx. I still have the clear there though. please have
look. i think it make sense.


On 30 July 2014 15:47, justin-short <notifications@github.com> wrote:

> In src/main/java/net/nous/open/logback/SlackWebhookAppender.java:
>
> >      }
> >
> > -	private void send(final ILoggingEvent evt) {
> > +	private void addEventToBuffer(final ILoggingEvent evt) {
> > +		if (eventBuffer.size() < MAX_EVENT_BUFFER_SIZE)
>
> Calling .size() on a concurrent queue is generally not a good idea,
> especially when using a linked queue. Why is the check required? (And 20
> seems rather small in 10 seconds). Can always check it on the append side
> of the equation, then you can print eg "... and 1000 more"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nousinc/nous-open/pull/4/files#r15570141>.
>