Update README.md
Visibility - field name hides field in superclass - unfortunately only one occurrence could be fixed, the rest are all `_log` overrides.
Visibility - inner class field hides outer class field - renamed two fields. Also changed public fields to private because they were only used within this final class.
Visibility - local variable hides field. Since the private field is always overwritten on access, it can be inlined, and then the hiding is also resolved.
Visibility - method overrides private method of superclass. L2AttackableAI is only extended by L2ControllableMobAI, so this is a decent solution.
Visibility - parameter hides field
Verbose or redundant code constructs - redundant array creation (getConstructor takes varargs)
Verbose or redundant code constructs - redundant type cast
Trailing spaces in properties
auto-closeable used without try-with-resources
Assignment issues - constructor assigns value to field defined in superclass. Also only the easy part.
Minor cleanup after merge.
Fixing minor typo from L2J/L2J_Server@ac426d90c3f02bb4f1916f1d23314c365c306907 preventing multisells and other bypasses to be properly formed (NPC Object ID) from onAdvTalk().
Reported by: @u3games
Visibility - class escapes defined scope.
Visibility - method overrides static method of superclass. There's still CellPathFinding/GeoPathFinding.getInstance() overriding PathFinding.getInstance(), but reworking that requires a commit to both core and dp.
Verbose or redundant code constructs - redundant type arguments
Assignment issues - assignment to null
Assignment issues - assignment to static field from instance parameter. Also moved Config.DATABASE_MAX_CONNECTIONS value check to Config class and optimized the related code a bit. There's actually a ton more of these static assignments from objects, but they're quite bothersome to deal with, some of the classes should be completely reworked.
Assignment issues - result of assignment used. Getting rid of a bad practice where the result of an assignment is returned/compared/assigned to another variable in the same line. That makes for confusing code. Some Stream API was used, in particular in iteration over lines of text in files.
Class structure - field can be local. Many fields were localized (where they were read, they were written to before reading, thus no point in storing them in the object), some fields were made static because they were supposed to be (packet names and similar stuff).