Squashed search panel view commits and


SystemUI: NavbarEditor: Fix saveKeys logic

In landscape, the keys are saved backwards in the for-loop, but it would crash out due from
an IndexOutOfBounds error since it's subtracting i from the array length while i = 0.

Change-Id: I405c5d962d8c575cfee57b09a7e55a8a6efc2d24

SystemUI: Rework SearchPanelView calculations

Make isScreenLarge calculations match how the system calculates where to put the navigation
bar. This fixes certain cases where the quick launch buttons on the glowpad of the
navigation bar is improperly oriented.

Change-Id: I5703578b4d49a6eeab100bb23167abd5cf9a326d

SystemUI: Fix SearchPanelView miscalculation

The SystemUI declares the navbar to be movable to the side in landscape when the short
side's DP calculation equals to less than 600. This means that the nav bar will be at the
bottom/the screen is considered "large" if it's greater OR EQUAL to 600, not just greater.

Fixes OMNI-1129 and OMNI-1130.

Change-Id: I90322e40ebf0c4bb94146e28eb2d9b8f8a4444f8

SystemUI: SearchPanelView: Optimize calculations

Only calculate if the screen is large once on initialization rather than every
time updateSettings() is called.

Change-Id: Ib54b6ef0ad6a987e75d6d98b5b269fc6e8f5104c