Graph is still there and it calls plot_timeseries

From: Ritesh Maheshwari <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wednesday, March 5, 2014 11:17 AM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Shaoshan Liu <shliu@linkedin.com<mailto:shliu@linkedin.com>>
Subject: Re: [naarad] Add CDF support to Naarad (#143)


In src/naarad/metrics/metric.py:

> @@ -308,21 +307,19 @@ def calc(self):
>              NEW_FH.write(str(new_metric_val))
>              NEW_FH.write('\n')
>
> -  def graph(self, graphing_library = 'matplotlib'):
> -    html_string = []
> -    html_string.append('<h1>Metric: {0}</h1>\n'.format(self.metric_type))
> +  def plot_timeseries(self, graphing_library = 'matplotlib'):


It looks like you have renamed 'graph' method to 'plot_timeseries'. But this will break everything since every metric expects graph method.

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/143/files#r10313651>.