Cleanup SplitStringIntoKeyaluePairs implementation.

This function was originally a helper function for sync and wasn't cleaned up/revisited since its move to base/ .
Since there are now several users of this function, we should care about a cleaner implementation.

While at string_split.cc, moving local functions (which partially were missing 'static') to an anonymous namespace.

BUG=NONE

Review URL: https://codereview.chromium.org/184233010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256226 0039d316-1c4b-4281-b951-d872f2087c98
Updating trunk VERSION from 1884.0 to 1885.0

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256227 0039d316-1c4b-4281-b951-d872f2087c98
Mac OS X: Show the Translate icon on Omnibox

This patch is the first step to implement the Translate bubble UX to
replace the current infobar. This patch fixes the Ominbox to show the
translate icon when a foreign page is loaded. This icon offers the
information to users if the page is translable or not, or if the page is
already translated or not. The icon turns blue when the page is
translated. As for screenshots, please see crbug/307352#c17.

By clicking the icon, the Translte bubble is shown. For now, the
Translate bubble is dummy and empty. I'll implement this and upload
another CL later.

Now this bubble is behind the flag --enable-translate-new-ux on Mac.
This bubble UX is already implemented and enabled by default on Aura
like Windows and Chrome OS.

BUG=307352

Review URL: https://codereview.chromium.org/151283006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256228 0039d316-1c4b-4281-b951-d872f2087c98
Only require tracing of immediate bases if they inherit a non-pure trace method.

This change also checks the formal parameter type is Visitor when identifying tracing methods.

R=ager@chromium.org
BUG=334149
NOTRY=true

Review URL: https://codereview.chromium.org/190543011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256229 0039d316-1c4b-4281-b951-d872f2087c98
More TSan v2 suppressions:
 -- races in third_party/WebKit/Source/heap/ThreadState.cpp (issue 347559)

BUG=347559
TBR=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/195173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256230 0039d316-1c4b-4281-b951-d872f2087c98
SVN changes up to revision 256230