mla: deny access to specific ID for users in user level API

User who don't have manipulate_permission action group
should not see users in system, even he shouldn't access
them directly by their ID's.

Change-Id: I90ec94fd0194680548e159f5d9bc010f5c233b91
Bug-Url: https://bugzilla.redhat.com/1160443
Signed-off-by: Ondra Machacek <machacek.ondra@gmail.com>
jsonrpc: version bump

New version of jsonrpc with jackson parsing flags.


Change-Id: I2a3fdf2835c49c3555796e9d4f26b3cc2aec96bc
Signed-off-by: pkliczewski <piotr.kliczewski@gmail.com>
Bug-Url: https://bugzilla.redhat.com/1155146
userportal,webadmin: Multi view table columns inconsistent

- since a463914769e87b5fb55999bcd25d56167b8e3d16 columns
  available in all view would not get removed and would
  always end up at the front of the grid even if other
  columns that can disappear were in front of them. This
  patch fixes that problem.

Change-Id: I143894af611f8364da943433e81378690adcb0e8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1157215
Signed-off-by: Alexander Wels <awels@redhat.com>
webadmin: refresh button wrapping

- Fixed refresh button wrapping when there is not enough room to fit
  all the buttons.

Change-Id: I1fc13aea7950ab3f4965131dcc2b32e4ea837192
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1163929
Signed-off-by: Alexander Wels <awels@redhat.com>
core: Use debug on register operation.

When register a disk with snapshot,
there is no reason to log an error but instead only use a debug level log.

Change-Id: If302d623ab13217776e0cb6ec49dda9cc59b7b39
Bug-Url: https://bugzilla.redhat.com/1136808
Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com>
Remove suffix from mgmt address taken from the ComputerResource conf

This parameter is used by ovirt-node and should include only fqdn or ip4
addr with port number or without. For example 10.35.1.85:8080

Change-Id: I5a40ca0b4870d1955b01d18c88df467b8da35fc4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167189
Signed-off-by: Yaniv Bronhaim <ybronhei@redhat.com>
aaa: Retrive values from domain using case insensitve name of the domain

This patch is aimed to solve case sensitivy issues for FreeIPA when
upgrading from 3.4 to 3.5

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167211
Change-Id: Ieeaf9c922d6d3f0b9bd2a4480859c4ce483454f9
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com>
core: minor refactor for custom props validation

instead of calling one method to check the properties and then another
to check the result, now calling one method to do both.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1166632
Change-Id: I444f374d0c1bb4c495b3c2b1c26c92bc466e19c9
Signed-off-by: Omer Frenkel <ofrenkel@redhat.com>
core: AuditLogMessage for internal disk addition

When adding a disk as part of an internal command - when no user is
involved, the <UNKNOWN> user was specified as user. This is now
corrected and new audit log messages were added with no user
specification in the message.

Change-Id: Ia66bb5fb393802cbfe6847240d6adfbbd1a53e4e
Bug-Url: https://bugzilla.redhat.com/1149620
Signed-off-by: Vered Volansky <vvolansk@redhat.com>
core: Add Video managed device for VM's/Template's OVF.

The number of monitors data in the Template should be part of the OVF
data.
so the information will still be availale after the attach of
a Storage Domain with import of existing entities.

This information consists in the video device of the entity, therefore
the fix adds video devices while building the OVF data, same as being
done in the export VM/Template process.

Change-Id: I5583edadd75bce7dfb3f5ba04cfcbe38f1dc7091
Bug-Url: https://bugzilla.redhat.com/1136902
Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com>
engine: Enhance the xml-rpc Long support to deal with Maps and Lists

It is common to have a Long value in a sub-map of an xml-rpc
argument. The current implementation does not deal with this case.

The ideal solution to this would be to instruct the marshaller
to do this. Unfortunately that is not possible and we have to
work around that limitation.

Change-Id: I5a5933a68f937c4734b547c173188e88bd7b9464
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145665
Signed-off-by: Martin Sivák <msivak@redhat.com>
engine: Use proper units in Storage QoS when talking to VDSM

The engine used Mbps and VDSM expects B/s. This patch changes
the engine side to use MB/s (as is more common when dealing with
storage) and properly translates that to Bytes when sending the
value to VDSM.

Change-Id: I2644e9e029c8b6ebe4b5b7626f7b1ed6b6b5aea4
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621
Signed-off-by: Martin Sivák <msivak@redhat.com>
engine: Enable Long xmlrpc support for new VM and disk hotplug

This is needed for the two commands to support Long based
values in the ioTune QoS policy parameters.

Change-Id: I82673b6dec7ba320c56a1cf6e0cd3f1dde86fd22
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145621
Signed-off-by: Martin Sivak <msivak@redhat.com>
Revert "setup: Changing task cleaner utility to also handle removal of commands"

This reverts commit a5462c7356b90b1465e05f4bb84f63a0005892bc.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167769
Change-Id: I5f08ff501606d06907704b60c57e950837d4e162
Signed-off-by: Yair Zaslavsky <yzaslavs@redhat.com>
core: Adding an existing block Storage Domain should be blocked

Adding an existing Storage Domain should be blocked by a CDA message

Change-Id: Iba5194e4c87ba96a7482fa52b18a2e9812663c7e
Bug-Url: https://bugzilla.redhat.com/1148803
Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com>
core: Add lock when importing an exsiting block Storage Domain

Add memory lock while importing an existing block Storage Domain.

Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174
Bug-Url: https://bugzilla.redhat.com/1148803
Signed-off-by: Maor Lipchuk <mlipchuk@redhat.com>
core: Push ioTune QoS info when hotplugging disk

This adds the support for disk QoS for disks that are hotplugged
while the VM is already running.

Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1145665
Signed-off-by: Martin Sivák <msivak@redhat.com>
core: Fix Live Merge recovery with JSON-RPC hosts

JSON-RPC calls to the reconcileVolumeChain verb were not done correctly,
causing recovery to fail if live merge was interrupted by e.g. host
shutdown during the merge operation.

Change-Id: If1b23580ae6023754d2e02000dc5913262b3ef8b
Bug-Url: https://bugzilla.redhat.com/1161127
Signed-off-by: Greg Padgett <gpadgett@redhat.com>
core: update vm version for pool-vm

When pool-vm is started by admin, it is not attached to any user, nor
doest it have a stateless snapshot.
so in this case, the logic that check if new version exists is skipped.

this patch calls restoreStatelessSnapshot (that contains the new version
logic) also to pool vms that are not attached to any user.

Change-Id: Ibce7bc6d744a0bc4ef42e7f039e880c595e44f89
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1167102
Signed-off-by: Omer Frenkel <ofrenkel@redhat.com>
core: tpgt should not be sent when empty

Ensure 'tpgt' isn't sent as an empty string as VDSM expects an integer.
I.e. 'tpgt' is optional, but if specified, it must be an integer.

Vdsm API:
"
{'type': 'IscsiConnectionParameters',
 'data': {'portal': 'IscsiPortal', 'iqn': 'str', '*tpgt': 'int',
          '*iface': 'str', '*credentials': 'IscsiCredentials'}}

@tpgt: #optional The Target Portal Group Tag to use
"

Change-Id: I79b6b80fafff7b87700e4e340eacff6cd0c43f30
Bug-Url: https://bugzilla.redhat.com/1160785
Signed-off-by: Daniel Erez <derez@redhat.com>