ContentHelperRoute::getArticleRoute needs to be called with catid and language

While working on #5140, I noticed that we never use the language value of the article when calculating the URL for it. Basically it means that we don't care if an english article is assigned to a french menu item, etc. Long story short: If you want to get the right URL, you need to provide the article ID, the category ID and the language.

Testing instructions: See that Joomla now creates the same and right URLs everywhere. Except for the TOS in the user plugin... Can't fix that one...
This testing instructions actually mean, that this needs a code review rather than a test.

For those looking for numbers: We have 35 files where ContentHelperRoute::getArticleRoute is called. Only in 3 of those files we are using the right language parameter.
I have no idea. Most likely you are right and I rewrote it to work with a contact. That still leaves the print popup a few lines further down, which I doubt is supported in com_contact. Or am I wrong?
The funny thing is, that this class is not used anywhere in Joomla. com_contact neither calls the icon class itself, nor does it load a layout that uses it. Or specifically JHtmlIcon::email(). I would be so bold to say that no one ever tested if this code works. I personally would remove the whole file here and now. Since it never worked, no one will ever have used it and thus there is no B/C issue. :stuck_out_tongue: