Why should it it accept a format it doesn't support and later possible
crash? That is beyond me.

When player configures renderer it is too late to make any further
decisions.

I can buy an argument that it should disable support in the supports call,
to force colorspace conversion in player.

But that still doesn't say that we should crash if something else is
requested.

That is the whole point of the fall through code after processor open.
On Feb 13, 2014 7:40 AM, "Voyager1" <notifications@github.com> wrote:

> In xbmc/cores/VideoRenderers/WinRenderer.cpp:
>
> >    {
> > -    m_formats.push_back(RENDER_FMT_YUV420P10);
> > -    m_formats.push_back(RENDER_FMT_YUV420P16);
> > +    if (g_Windowing.IsTextureFormatOk(D3DFMT_L16, 0))
> > +    {
> > +      m_formats.push_back(RENDER_FMT_YUV420P10);
> > +      m_formats.push_back(RENDER_FMT_YUV420P16);
> > +    }
>
> And so it always ends... (Sigh)
> @Shine- <https://github.com/Shine-> please be a bit more patient and
> persistent, some team devs are quite difficult to work with. This is not
> the moment to give up and who knows ultimately differences of opinion and
> language barriers may be removed and an even better solution could come out
> of this.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/xbmc/xbmc/pull/4192/files#r9699251>
> .
>