wrote rspec tests