yes, sorry. Will update the PR later. Probably should extract the completer
anyway.
I really think Groovy should not try to compete with Scala, Kotlin, Xtend,
Fantom, etc. Groovy should compete with Ruby and Python. And a good REPL is
tremendously valuable in that respect.


On Wed, Jan 15, 2014 at 11:59 PM, PascalSchumacher <notifications@github.com
> wrote:

> In
> subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/commands/AliasCommand.groovy:
>
> > @@ -30,7 +32,14 @@ class AliasCommand
> >      extends CommandSupport
> >  {
> >      AliasCommand(final Groovysh shell) {
> > -        super(shell, ':alias', ':a')
> > +        super(shell, ':alias', ':a', )
> > +    }
> > +
> > +    protected List createCompleters() {
> > +        return [
> > +                new HelpCommandCompletor(registry),
>
> shouldn't this be AliasCommandCompleter? btw it's very nice that you
> submit so many enhancements to groovysh :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/groovy/groovy-core/pull/311/files#r8916322>
> .
>