Copying a WebPreferences object should be done through a member function
https://bugs.webkit.org/show_bug.cgi?id=128385

Reviewed by Andreas Kling.

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreateCopy):
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::copy):
* UIProcess/WebPreferences.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Web Inspector: Clean up DataGrid and add table columns incrementally
https://bugs.webkit.org/show_bug.cgi?id=128332

Reviewed by Timothy Hatcher.

Miscellaneous improvements to DataGrid to make it more maintainable.
In particular, it now uses a `Map` to store column settings, and the
construction sequence has been simplified so that it is safe to add
columns at the end of the constructor (or any later time).

DataGrid stores a bunch of settings per-column, but before this was done
by both storing properties on the provided `column` objects as well as
keeping several `columnIdentifier`-keyed maps for properties like `group`
and `hidden`.

Improve code readability by using for..of loops, destructuring assignment,
`Node.createElement`, and updating variable names. All variables that refer
to DOM nodes now have a `Element` suffix to distinguish them from model objects.

* UserInterface/DataGrid.js:
(.sortDataGrid):
(WebInpector.DataGrid): Create all DOM elements before populating columns.
Remove redundant objects for storing per-column values. Copy column settings
into a map rather than mutating the passed-in JSON-like settings data structure.

(WebInspector.DataGrid.createSortableDataGrid):
(WebInspector.DataGrid.prototype.get length):
(WebInspector.DataGrid.prototype.updateLayout):
(WebInspector.DataGrid.prototype.get scrollContainer):
(WebInspector.DataGrid.prototype.isScrolledToLastRow):
(WebInspector.DataGrid.prototype.scrollToLastRow):
(WebInspector.DataGrid.prototype._positionResizerElements):
(WebInspector.DataGrid.prototype.addCreationNode):
(WebInspector.DataGrid.prototype.):
(WebInspector.DataGrid.prototype.sortNodes):
(WebInspector.DataGrid.prototype.dataGridNodeFromPoint):
(WebInspector.DataGrid.prototype._clickInHeaderCell):
(WebInspector.DataGrid.prototype.isColumnSortColumn):
(WebInspector.DataGrid.prototype.headerTableHeader):
(WebInspector.DataGrid.prototype._copyTextForDataGridNode):
(WebInspector.DataGrid.prototype._resizerDragging):
(WebInspector.DataGridNode.prototype.createCells):
(WebInspector.DataGridNode.prototype.createCell.get var):
(WebInspector.DataGridNode.prototype.elementWithColumnIdentifier):
(WebInspector.DataGridNode.prototype._attach):
* UserInterface/TimelineDataGrid.js:
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters.scopeBar.this.columns.get scopeBar):
(WebInspector.TimelineDataGrid.prototype.treeElementMatchesActiveScopeFilters):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Convert ProgressTracker to std::chrono
https://bugs.webkit.org/show_bug.cgi?id=128377

Reviewed by Andreas Kling.

* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
* loader/ProgressTracker.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r160628): LLint does not appear to handle impure get own property properly
https://bugs.webkit.org/show_bug.cgi?id=127943

Reviewed by Filip Pizlo.

Make sure the LLINT doesn't attempt to cache property
access on structures with impureGetOwnPropertySlot set.

* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rename ViewGestureController.mm to ViewGestureControllerMac.mm
https://bugs.webkit.org/show_bug.cgi?id=128387

Reviewed by Anders Carlsson.

As a precursor to having a second nearly completely divergent
ViewGestureController implementation for iOS.

* UIProcess/mac/ViewGestureControllerMac.mm: Renamed from Source/WebKit2/UIProcess/mac/ViewGestureController.mm.
* WebKit2.xcodeproj/project.pbxproj:
Rename ViewGestureController.mm to ViewGestureControllerMac.mm.
Unfortunately, since we're not renaming the class, the header
has to keep its name (and will be the recipient of a giant #if in a later
patch), because the message receiver generated code will try to import
ViewGestureController.h (without the Mac suffix).


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed build fix for 32-bit iOS.

Use magic ? values to allow the exported symbol to be different on 32- and 64-bit builds.

* WebCore.exp.in:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Build fix after r163632

Unreviewed EFL build fix

Added empty stub to WKTR to not break EFL build.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::selectTextWithCriteria):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reenable AppNap
https://bugs.webkit.org/show_bug.cgi?id=128394

Reviewed by Tim Horton.

* Shared/WebPreferencesStore.h:
    - pageVisibilityBasedProcessSuppressionEnabled shoud default to true.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Simplify WebPreferences creation inside WebPageGroup
https://bugs.webkit.org/show_bug.cgi?id=128392

Reviewed by Andreas Kling.

Always create a WebPreferences object when creating the web page group.
This is another step towards letting WebPageProxy manage web preferences.

* UIProcess/WebPageGroup.cpp:
(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):
(WebKit::WebPageGroup::~WebPageGroup):
(WebKit::WebPageGroup::setPreferences):
(WebKit::WebPageGroup::preferences):
* UIProcess/WebPageGroup.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@163644 268f45cc-cd09-0410-ab3c-d52691b4dbfc