Which line is this?
I don’t see this in my workspace.

Thanks,
-Joy

From: Ritesh Maheshwari <notifications@github.com<mailto:notifications@github.com>>
Reply-To: linkedin/naarad <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wednesday, April 23, 2014 at 5:36 PM
To: linkedin/naarad <naarad@noreply.github.com<mailto:naarad@noreply.github.com>>
Cc: Chaoyue Xiong <cxiong@linkedin.com<mailto:cxiong@linkedin.com>>
Subject: Re: [naarad] Add support for data groupby (#200)


In src/naarad/metrics/metric.py:

>        self.titles = dict(zip(self.columns, self.titles_string.split(','))) if self.columns and self.titles_string else None
>        self.ylabels = dict(zip(self.columns, self.ylabels_string.split(','))) if self.columns and self.ylabels_string else None
>
> +  def name_to_index(self, name):
> +    index = None
> +    for i in range(len(self.columns)):
> +      if name == self.columns[i]:
> +        index = i+1
> +    return index
> +
> +  def get_groupby_indexes(self, groupby):
> +    groupby_indexes = []
> +    for i in range(len(groupby)):


Change this to pythonic way please (not looping over i)

—
Reply to this email directly or view it on GitHub<https://github.com/linkedin/naarad/pull/200/files#r11931731>.